From 71dc66a9b3b3945eebedb0440933aea1c693af95 Mon Sep 17 00:00:00 2001 From: Bill Richardson Date: Wed, 9 Jul 2014 21:47:32 -0700 Subject: [PATCH] Cleanup: remove some noisy output from some utilities There are a few utilities that print the full path of any file they open. This isn't necessary, and it just has to be ignored when running regression tests from different directories. This just removes that extra noise. BUG=chromium:224734 BRANCH=ToT TEST=make runtests Change-Id: I4291bca7952a0d7371f8682b7d57545361c6341c Signed-off-by: Bill Richardson Reviewed-on: https://chromium-review.googlesource.com/207619 Reviewed-by: Randall Spangler --- futility/cmd_dump_fmap.c | 2 -- utility/eficompress.c | 2 -- utility/efidecompress.c | 2 -- utility/load_firmware_test.c | 2 -- 4 files changed, 8 deletions(-) diff --git a/futility/cmd_dump_fmap.c b/futility/cmd_dump_fmap.c index 4faf221292..fbd96209a9 100644 --- a/futility/cmd_dump_fmap.c +++ b/futility/cmd_dump_fmap.c @@ -433,8 +433,6 @@ static int do_dump_fmap(int argc, char *argv[]) strerror(errno)); return 1; } - if (FMT_NORMAL == opt_format) - printf("opened %s\n", argv[optind]); base_of_rom = mmap(0, sb.st_size, PROT_READ|PROT_WRITE, MAP_PRIVATE, fd, 0); if (base_of_rom == (char*)-1) { diff --git a/utility/eficompress.c b/utility/eficompress.c index dfa0d71fe2..7c83fd3b95 100644 --- a/utility/eficompress.c +++ b/utility/eficompress.c @@ -1651,7 +1651,6 @@ int main(int argc, char *argv[]) strerror(errno)); exit(1); } - printf("opened %s\n", infile); // read input file into buffer uint8_t *ibuf = malloc(isize); @@ -1702,7 +1701,6 @@ int main(int argc, char *argv[]) strerror(errno)); goto done3; } - printf("opened %s\n", outfile); if (1 != fwrite(obuf, osize, 1, ofp)) { fprintf(stderr, "%s: can't write %d bytes: %s\n", diff --git a/utility/efidecompress.c b/utility/efidecompress.c index 0258720575..8a90a6ad7d 100644 --- a/utility/efidecompress.c +++ b/utility/efidecompress.c @@ -1050,7 +1050,6 @@ int main(int argc, char *argv[]) strerror(errno)); exit(1); } - printf("opened %s\n", infile); // read input file into buffer uint8_t *ibuf = malloc(isize); @@ -1129,7 +1128,6 @@ int main(int argc, char *argv[]) strerror(errno)); goto done4; } - printf("opened %s\n", outfile); if (1 != fwrite(obuf, osize, 1, ofp)) { fprintf(stderr, "%s: can't write %d bytes: %s\n", diff --git a/utility/load_firmware_test.c b/utility/load_firmware_test.c index 62b9c34852..062d8e75e3 100644 --- a/utility/load_firmware_test.c +++ b/utility/load_firmware_test.c @@ -240,8 +240,6 @@ int main(int argc, char* argv[]) { exit(1); } - printf("opened %s\n", image_path); - fmap = FmapFind((char*) base_of_rom, rom_size); retval = DriveLoadFirmware(base_of_rom, fmap, boot_flags);