From 756141d6b92b0cffe7fca4226f096151af149bee Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Mon, 30 Apr 2018 09:37:00 -0700 Subject: [PATCH] eve: Limit data role swap to port 0 Only USB port 0 is capable of device mode, so ignore data role swaps to other ports. BUG=b:78308749 BRANCH=eve TEST=manual: ensure OTG pins are not asserted with data role swap on port 1. Change-Id: I07a331af11c3ce599a75517a5ba0ff2716987545 Signed-off-by: Duncan Laurie Reviewed-on: https://chromium-review.googlesource.com/1035424 Reviewed-by: Furquan Shaikh --- board/eve/usb_pd_policy.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/board/eve/usb_pd_policy.c b/board/eve/usb_pd_policy.c index 8dc3de611d..8c2226b444 100644 --- a/board/eve/usb_pd_policy.c +++ b/board/eve/usb_pd_policy.c @@ -191,6 +191,10 @@ int pd_check_vconn_swap(int port) void pd_execute_data_swap(int port, int data_role) { + /* Only port 0 supports device mode. */ + if (port != 0) + return; + gpio_set_level(GPIO_USB2_OTG_ID, (data_role == PD_ROLE_UFP) ? 1 : 0); gpio_set_level(GPIO_USB2_OTG_VBUSSENSE,