From 7832ba6c4f9783d6ccb934b33028bb8adee07747 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Thu, 11 Aug 2016 11:56:38 -0600 Subject: [PATCH] tcpm/anx74xx: initialize reg variable before use When disabling auto_good_crc, the reg variable was being used without initialization. Mirror the code for enabling auto_good_crc to set the variable. TEST=Booted reef with updated code. BUG=None BRANCH=None Change-Id: Ie552f2ff74df05750bd65b6344d8a80cc285f8b0 Signed-off-by: Martin Roth Reviewed-on: https://chromium-review.googlesource.com/368221 Reviewed-by: David Hendricks --- driver/tcpm/anx74xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/driver/tcpm/anx74xx.c b/driver/tcpm/anx74xx.c index cdba2c8acb..0465a5179e 100644 --- a/driver/tcpm/anx74xx.c +++ b/driver/tcpm/anx74xx.c @@ -44,6 +44,8 @@ static void anx74xx_tcpm_set_auto_good_crc(int port, int enable) tcpc_read(port, ANX74XX_REG_TX_AUTO_GOODCRC_1, ®); reg |= ANX74XX_REG_AUTO_GOODCRC_EN; } else { + /* Clear bit-0 for disable */ + tcpc_read(port, ANX74XX_REG_TX_AUTO_GOODCRC_1, ®); reg &= ~ANX74XX_REG_AUTO_GOODCRC_EN; tcpc_write(port, ANX74XX_REG_TX_AUTO_GOODCRC_2, 0); }