From 7d1114f42edc82ffe3cb1060b08819fb4dd92f2b Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Sun, 28 Jan 2018 15:12:05 -0700 Subject: [PATCH] cbi-util: Help GCC determine that variable is initialized GCC 6.3 can't tell that we enforce the variable 'size' being set, so initialize it to 0 to make the warning go away. The code does actually verify that size is set, but not by checking the size variable itself. util/cbi-util.c: In function 'main': util/cbi-util.c:139:8: error: 'size' may be used uninitialized in this function [-Werror=maybe-uninitialized] buf = malloc(size); ^~~~~~~~~~~~ util/cbi-util.c:233:11: note: 'size' was declared here uint32_t size; ^~~~ BUG=b:72609872 BRANCH=None TEST=Build with coreboot toolchain. Change-Id: Ide41a0fce40254f2fa3a8626dec75840a728d967 Signed-off-by: Martin Roth Reviewed-on: https://chromium-review.googlesource.com/890703 Commit-Ready: Martin Roth Tested-by: Martin Roth Reviewed-by: Daisuke Nojiri Reviewed-by: Edward Hill Reviewed-by: Patrick Georgi Reviewed-by: Jett Rink --- util/cbi-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cbi-util.c b/util/cbi-util.c index e5ad554a03..d8b32c3468 100644 --- a/util/cbi-util.c +++ b/util/cbi-util.c @@ -230,7 +230,7 @@ int main(int argc, char **argv) int mode = OPT_MODE_NONE; const char *cbi_filename = NULL; struct board_info bi; - uint32_t size; + uint32_t size = 0; uint8_t erase = 0xff; int show_all = 0; int parse_error = 0;