From 7f3ca9fb659c85e046bfef8a794fc03111fd63c5 Mon Sep 17 00:00:00 2001 From: Randall Spangler Date: Tue, 22 Oct 2013 14:30:11 -0700 Subject: [PATCH] rambi: Remove internal pullup from write protect pin The pin has a 100k series resistor, which is overwhelmed by the internal pullup. BUG=chrome-os-partner:23489 BRANCH=none TEST=gpioget wp_l, with screw present and removed. With screw present, signal should read 0; with it removed it should read 1. Change-Id: I35ee867111d0d7e8626dd3ac8010e9a10f46ccf7 Signed-off-by: Randall Spangler Reviewed-on: https://chromium-review.googlesource.com/174094 Reviewed-by: Aaron Durbin --- board/rambi/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/rambi/board.c b/board/rambi/board.c index fbe32dd924..0ddfb7df7d 100644 --- a/board/rambi/board.c +++ b/board/rambi/board.c @@ -52,7 +52,7 @@ const struct gpio_info gpio_list[] = { x86_interrupt}, {"VCORE_PGOOD", LM4_GPIO_C, (1<<6), GPIO_INT_BOTH, x86_interrupt}, - {"WP_L", LM4_GPIO_A, (1<<4), GPIO_INT_BOTH|GPIO_PULL_UP, + {"WP_L", LM4_GPIO_A, (1<<4), GPIO_INT_BOTH, switch_interrupt}, /* Other inputs */