From 7fb019e43c416a5dac4bf23fa06242397b0f772a Mon Sep 17 00:00:00 2001 From: Alec Berg Date: Thu, 5 Jun 2014 11:58:15 -0700 Subject: [PATCH] samus: decrease stack size for smaller tasks Created a new smaller task size, 384, for tasks that don't need much stack space including PDCMD and ALS tasks. BUG=none BRANCH=none TEST=loaded on samus, ran taskinfo, made sure we were comfortbaly under the smaller task size for those tasks that changed. Change-Id: Icfa26eeaeed26171ec8b2d888e1190be32f688d1 Signed-off-by: Alec Berg Reviewed-on: https://chromium-review.googlesource.com/202719 Reviewed-by: Randall Spangler --- board/samus/ec.tasklist | 4 ++-- chip/lm4/config_chip.h | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/board/samus/ec.tasklist b/board/samus/ec.tasklist index ab25faa872..47aff323ed 100644 --- a/board/samus/ec.tasklist +++ b/board/samus/ec.tasklist @@ -18,12 +18,12 @@ */ #define CONFIG_TASK_LIST \ TASK_ALWAYS(HOOKS, hook_task, NULL, LARGER_TASK_STACK_SIZE) \ - TASK_NOTEST(ALS, als_task, NULL, TASK_STACK_SIZE) \ + TASK_NOTEST(ALS, als_task, NULL, SMALLER_TASK_STACK_SIZE) \ TASK_NOTEST(LIGHTBAR, lightbar_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_ALWAYS(CHARGER, charger_task, NULL, TASK_STACK_SIZE) \ TASK_NOTEST(CHIPSET, chipset_task, NULL, TASK_STACK_SIZE) \ TASK_NOTEST(KEYPROTO, keyboard_protocol_task, NULL, TASK_STACK_SIZE) \ - TASK_NOTEST(PDCMD, pd_command_task, NULL, TASK_STACK_SIZE) \ + TASK_NOTEST(PDCMD, pd_command_task, NULL, SMALLER_TASK_STACK_SIZE) \ TASK_ALWAYS(HOSTCMD, host_command_task, NULL, TASK_STACK_SIZE) \ TASK_ALWAYS(CONSOLE, console_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_ALWAYS(POWERBTN, power_button_task, NULL, TASK_STACK_SIZE) \ diff --git a/chip/lm4/config_chip.h b/chip/lm4/config_chip.h index 617e1aabfe..19b331966e 100644 --- a/chip/lm4/config_chip.h +++ b/chip/lm4/config_chip.h @@ -46,6 +46,7 @@ /* non-standard task stack sizes */ #define IDLE_TASK_STACK_SIZE 512 #define LARGER_TASK_STACK_SIZE 768 +#define SMALLER_TASK_STACK_SIZE 384 /* Default task stack size */ #define TASK_STACK_SIZE 512