From 8610346356a56d6f1b78f5eb9da456d11fc8264f Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Fri, 18 Aug 2017 11:36:58 -0700 Subject: [PATCH] lib/vboot_ui_menu: Consider volume buttons in vb2_update_selection vb2_update_selection considered only KEY_UP and KEY_DOWN inputs to update the selection. This resulted in volume buttons not working on firmware screen to update the selection. Add volume buttons as valid inputs in vb2_update_selection. BUG=b:64839396 BRANCH=None TEST=Verified that volume buttons work on firmware screen. Change-Id: I08bfa91eafb170fb450649a2abaafe7f4d58e17b Signed-off-by: Furquan Shaikh Reviewed-on: https://chromium-review.googlesource.com/621787 Reviewed-by: Aaron Durbin Reviewed-by: Shelley Chen --- firmware/lib/vboot_ui_menu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/firmware/lib/vboot_ui_menu.c b/firmware/lib/vboot_ui_menu.c index d7c647ca85..4bc0cffc6d 100644 --- a/firmware/lib/vboot_ui_menu.c +++ b/firmware/lib/vboot_ui_menu.c @@ -662,6 +662,7 @@ void vb2_update_selection(VbCommonParams *cparams, uint32_t key) { } switch (key) { + case VB_BUTTON_VOL_UP: case VB_KEY_UP: idx = current_menu_idx - 1; while (idx >= 0 && @@ -671,6 +672,7 @@ void vb2_update_selection(VbCommonParams *cparams, uint32_t key) { if (idx >= 0) current_menu_idx = idx; break; + case VB_BUTTON_VOL_DOWN: case VB_KEY_DOWN: idx = current_menu_idx + 1; while (idx < menu_size &&