mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2025-11-27 03:33:50 +00:00
cleanup: Fix some typos in comments
No code changes, just fix a few spelling errors and change C++ style comments to C-style. BUG=none BRANCH=none TEST=make runtests Change-Id: I153f821a3f42a92867c7dc4761a2bcde7f2518c4 Signed-off-by: Bill Richardson <wfrichar@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/256123 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
This commit is contained in:
committed by
ChromeOS Commit Bot
parent
64b3697297
commit
9c647efd7f
@@ -63,7 +63,7 @@ void vb2_nv_init(struct vb2_context *ctx)
|
|||||||
|
|
||||||
/* Set status flag */
|
/* Set status flag */
|
||||||
sd->status |= VB2_SD_STATUS_NV_REINIT;
|
sd->status |= VB2_SD_STATUS_NV_REINIT;
|
||||||
// TODO: unit test for status flag being set
|
/* TODO: unit test for status flag being set */
|
||||||
}
|
}
|
||||||
|
|
||||||
sd->status |= VB2_SD_STATUS_NV_INIT;
|
sd->status |= VB2_SD_STATUS_NV_INIT;
|
||||||
|
|||||||
@@ -50,7 +50,7 @@ int vb2_secdata_init(struct vb2_context *ctx)
|
|||||||
|
|
||||||
/* Set status flag */
|
/* Set status flag */
|
||||||
sd->status |= VB2_SD_STATUS_SECDATA_INIT;
|
sd->status |= VB2_SD_STATUS_SECDATA_INIT;
|
||||||
// TODO: unit test for that
|
/* TODO: unit test for that */
|
||||||
|
|
||||||
/* Read this now to make sure crossystem has it even in rec mode. */
|
/* Read this now to make sure crossystem has it even in rec mode. */
|
||||||
rv = vb2_secdata_get(ctx, VB2_SECDATA_VERSIONS,
|
rv = vb2_secdata_get(ctx, VB2_SECDATA_VERSIONS,
|
||||||
|
|||||||
@@ -35,7 +35,7 @@ enum vb2_signature_algorithm {
|
|||||||
|
|
||||||
/*
|
/*
|
||||||
* No signature algorithm. The digest is unsigned. See
|
* No signature algorithm. The digest is unsigned. See
|
||||||
* VB2_GUID_NONE_* above for key GUIDs to use with this algorithm.
|
* VB2_GUID_NONE_* for key GUIDs to use with this algorithm.
|
||||||
*/
|
*/
|
||||||
VB2_SIG_NONE = 1,
|
VB2_SIG_NONE = 1,
|
||||||
|
|
||||||
|
|||||||
@@ -104,7 +104,7 @@ enum vb2_nv_recovery {
|
|||||||
VB2_RECOVERY_EC_HASH_MISMATCH = 0x2a,
|
VB2_RECOVERY_EC_HASH_MISMATCH = 0x2a,
|
||||||
|
|
||||||
/* New error codes from VB2 */
|
/* New error codes from VB2 */
|
||||||
// TODO: may need to add strings for these in the original fwlib
|
/* TODO: may need to add strings for these in the original fwlib */
|
||||||
|
|
||||||
/* Secure data inititalization error */
|
/* Secure data inititalization error */
|
||||||
VB2_RECOVERY_SECDATA_INIT = 0x2b,
|
VB2_RECOVERY_SECDATA_INIT = 0x2b,
|
||||||
|
|||||||
@@ -381,7 +381,7 @@ enum vb2_return_code {
|
|||||||
*/
|
*/
|
||||||
VB2_ERROR_API = VB2_ERROR_BASE + 0x090000,
|
VB2_ERROR_API = VB2_ERROR_BASE + 0x090000,
|
||||||
|
|
||||||
/* Bag tag in vb2api_init_hash() */
|
/* Bad tag in vb2api_init_hash() */
|
||||||
VB2_ERROR_API_INIT_HASH_TAG,
|
VB2_ERROR_API_INIT_HASH_TAG,
|
||||||
|
|
||||||
/* Preamble not present in vb2api_init_hash() */
|
/* Preamble not present in vb2api_init_hash() */
|
||||||
@@ -411,22 +411,22 @@ enum vb2_return_code {
|
|||||||
/* Work buffer too small in vb2api_check_hash() */
|
/* Work buffer too small in vb2api_check_hash() */
|
||||||
VB2_ERROR_API_CHECK_HASH_WORKBUF_DIGEST,
|
VB2_ERROR_API_CHECK_HASH_WORKBUF_DIGEST,
|
||||||
|
|
||||||
/* Bag tag in vb2api_check_hash() */
|
/* Bad tag in vb2api_check_hash() */
|
||||||
VB2_ERROR_API_CHECK_HASH_TAG,
|
VB2_ERROR_API_CHECK_HASH_TAG,
|
||||||
|
|
||||||
/* Missing firmware data key in vb2api_check_hash() */
|
/* Missing firmware data key in vb2api_check_hash() */
|
||||||
VB2_ERROR_API_CHECK_HASH_DATA_KEY,
|
VB2_ERROR_API_CHECK_HASH_DATA_KEY,
|
||||||
|
|
||||||
/* Siganature size mismatch in vb2api_check_hash() */
|
/* Signature size mismatch in vb2api_check_hash() */
|
||||||
VB2_ERROR_API_CHECK_HASH_SIG_SIZE,
|
VB2_ERROR_API_CHECK_HASH_SIG_SIZE,
|
||||||
|
|
||||||
/* Phase one needs recovery mode */
|
/* Phase one needs recovery mode */
|
||||||
VB2_ERROR_API_PHASE1_RECOVERY,
|
VB2_ERROR_API_PHASE1_RECOVERY,
|
||||||
|
|
||||||
/* Bag tag in vb2api_check_hash() */
|
/* Bad tag in vb2api_check_hash() */
|
||||||
VB2_ERROR_API_INIT_HASH_GUID,
|
VB2_ERROR_API_INIT_HASH_GUID,
|
||||||
|
|
||||||
/* Siganature mismatch in vb2api_check_hash() */
|
/* Signature mismatch in vb2api_check_hash() */
|
||||||
VB2_ERROR_API_CHECK_HASH_SIG,
|
VB2_ERROR_API_CHECK_HASH_SIG,
|
||||||
|
|
||||||
/* Invalid enum vb2_pcr_digest requested to vb2api_get_pcr_digest */
|
/* Invalid enum vb2_pcr_digest requested to vb2api_get_pcr_digest */
|
||||||
|
|||||||
@@ -121,14 +121,14 @@ struct vb2_shared_data {
|
|||||||
uint32_t workbuf_data_key_size;
|
uint32_t workbuf_data_key_size;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Offset and size of firmware preamble in work buffer. Size if 0 if
|
* Offset and size of firmware preamble in work buffer. Size is 0 if
|
||||||
* preamble is not stored in the work buffer.
|
* preamble is not stored in the work buffer.
|
||||||
*/
|
*/
|
||||||
uint32_t workbuf_preamble_offset;
|
uint32_t workbuf_preamble_offset;
|
||||||
uint32_t workbuf_preamble_size;
|
uint32_t workbuf_preamble_size;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Offset and size of hash context in work buffer. Size if 0 if
|
* Offset and size of hash context in work buffer. Size is 0 if
|
||||||
* hash context is not stored in the work buffer.
|
* hash context is not stored in the work buffer.
|
||||||
*/
|
*/
|
||||||
uint32_t workbuf_hash_offset;
|
uint32_t workbuf_hash_offset;
|
||||||
|
|||||||
@@ -201,7 +201,7 @@ VbError_t LoadKernel(LoadKernelParams *params, VbCommonParams *cparams)
|
|||||||
goto bad_kernel;
|
goto bad_kernel;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* In developer mode, we can explictly disallow
|
* In developer mode, we can explicitly disallow
|
||||||
* self-signed kernels
|
* self-signed kernels
|
||||||
*/
|
*/
|
||||||
if (require_official_os) {
|
if (require_official_os) {
|
||||||
|
|||||||
@@ -160,8 +160,8 @@ int vb2api_check_hash(struct vb2_context *ctx)
|
|||||||
digest_size))
|
digest_size))
|
||||||
return VB2_ERROR_API_CHECK_HASH_SIG;
|
return VB2_ERROR_API_CHECK_HASH_SIG;
|
||||||
|
|
||||||
// TODO: the old check-hash function called vb2_fail() on any mismatch.
|
/* TODO: the old check-hash function called vb2_fail() on any mismatch.
|
||||||
// I don't think it should do that; the caller should.
|
* I don't think it should do that; the caller should. */
|
||||||
|
|
||||||
return VB2_SUCCESS;
|
return VB2_SUCCESS;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -651,7 +651,7 @@ static void VbInitTestBackup(void)
|
|||||||
TEST_EQ(shared->flags, VBSD_BOOT_DEV_SWITCH_ON, " shared flags");
|
TEST_EQ(shared->flags, VBSD_BOOT_DEV_SWITCH_ON, " shared flags");
|
||||||
TEST_EQ(backup_write_called, 1, " Once more, one backup");
|
TEST_EQ(backup_write_called, 1, " Once more, one backup");
|
||||||
|
|
||||||
/* But if we explictly request a backup, they'll get saved. */
|
/* But if we explicitly request a backup, they'll get saved. */
|
||||||
VbNvSet(&vnc, VBNV_BACKUP_NVRAM_REQUEST, 1);
|
VbNvSet(&vnc, VBNV_BACKUP_NVRAM_REQUEST, 1);
|
||||||
VbNvTeardown(&vnc);
|
VbNvTeardown(&vnc);
|
||||||
TestVbInit(0, 0, "Dev mode on");
|
TestVbInit(0, 0, "Dev mode on");
|
||||||
|
|||||||
@@ -56,7 +56,7 @@ class BmpBlockUtil {
|
|||||||
BmpBlockUtil(bool debug);
|
BmpBlockUtil(bool debug);
|
||||||
~BmpBlockUtil();
|
~BmpBlockUtil();
|
||||||
|
|
||||||
/* Load all the images and related infomations according to a config file. */
|
/* Load all the images and related information according to a config file. */
|
||||||
void load_from_config(const char *filename);
|
void load_from_config(const char *filename);
|
||||||
|
|
||||||
/* Contruct the bmpblock. */
|
/* Contruct the bmpblock. */
|
||||||
|
|||||||
Reference in New Issue
Block a user