From 9e73f3e0318c992d7cf50164edb0645c2d363205 Mon Sep 17 00:00:00 2001 From: Aseda Aboagye Date: Thu, 25 Jun 2015 09:36:10 -0700 Subject: [PATCH] presubmit: Add hook to check for config options. This enables a presubmit hook to check for missing configuration options. All CONFIG_* options should be defined in include/config.h along with a brief description of what the config option does. BUG=chrome-os-partner:26304 BRANCH=none CQ-DEPEND=CL:281626 TEST=Create a commit modifying a source file with a new CONFIG_* option and watched the preupload process fail illustrating the error with the CONFIG_* option. TEST=make -j buildall tests Change-Id: I7240b386b4981dcab66811a4829d7d6ebfbf7cb1 Signed-off-by: Aseda Aboagye Reviewed-on: https://chromium-review.googlesource.com/281826 Reviewed-by: Randall Spangler Tested-by: Aseda Aboagye Commit-Queue: Aseda Aboagye Trybot-Ready: Aseda Aboagye --- PRESUBMIT.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg index a4d1071940..bf39804563 100644 --- a/PRESUBMIT.cfg +++ b/PRESUBMIT.cfg @@ -11,3 +11,4 @@ checkpatch_check: --no-tree --ignore=MSLEEP,VOLATILE [Hook Scripts] hook0 = util/presubmit_check.sh 2>&1 +hook1 = util/config_option_check.py 2>&1 \ No newline at end of file