From a2552fdfba11ac0a82fd9f2be87e6e84fd4180dc Mon Sep 17 00:00:00 2001 From: Vijay Hiremath Date: Thu, 1 Sep 2016 09:36:30 -0700 Subject: [PATCH] reef: Trigger interrupt on both the edges for volume button GPIOs Both press and release of the volume button has to be detected in order to process volume changes. Hence, trigger the interrupt on both the edges for volume button GPIOs. BUG=chrome-os-partner:56856 BRANCH=none TEST=Volume slider can slide when volume buttons are pressed. Change-Id: I0655f1c494d754904987cc2c76dcb3a39d5670ab Signed-off-by: Vijay Hiremath Reviewed-on: https://chromium-review.googlesource.com/379621 Commit-Ready: Vijay P Hiremath Tested-by: Vijay P Hiremath Reviewed-by: Kevin K Wong Reviewed-by: Shawn N --- board/reef/gpio.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/reef/gpio.inc b/board/reef/gpio.inc index ffba5edbae..c9d8c481d2 100644 --- a/board/reef/gpio.inc +++ b/board/reef/gpio.inc @@ -34,8 +34,8 @@ GPIO_INT(AC_PRESENT, PIN(C, 1), GPIO_INT_BOTH, extpower_interrupt) /* ACOK_OD GPIO_INT(POWER_BUTTON_L, PIN(0, 4), GPIO_INT_BOTH, power_button_interrupt) /* MECH_PWR_BTN_ODL */ /* FIXME(furquan): GPIO_PULL_UP is not required for LID_OPEN on EVT. */ GPIO_INT(LID_OPEN, PIN(6, 7), GPIO_INT_BOTH | GPIO_PULL_UP, lid_interrupt) -GPIO_INT(EC_VOLDN_BTN_L, PIN(8, 3), GPIO_INT_LOW | GPIO_PULL_UP, button_interrupt) -GPIO_INT(EC_VOLUP_BTN_L, PIN(8, 2), GPIO_INT_LOW | GPIO_PULL_UP, button_interrupt) +GPIO_INT(EC_VOLDN_BTN_L, PIN(8, 3), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) +GPIO_INT(EC_VOLUP_BTN_L, PIN(8, 2), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) GPIO_INT(WP_L, PIN(4, 0), GPIO_INT_BOTH | GPIO_SEL_1P8V, switch_interrupt) /* EC_WP_ODL */