Get rid of some crufty macros.

These were macros that were never used, or that were only set to one thing and
could be substituted up front.

I left in code guarded by the HAVE_ENDIAN_H and HAVE_LITTLE_ENDIAN macros even
though those are never defined because they guard a reportedly significantly
faster implementation of some functionality, at least according to a comment
in the source. It would be a good idea to enable that code path and see if it
really does make a big difference before removing it entirely.

BUG=None
TEST=Built for Link, Daisy, and the host with FEATURES=test. Built depthcharge
for Link and booted in normal mode.
BRANCH=None

Change-Id: I934a4dd0da169ac018ba07350d56924ab88b1acc
Signed-off-by: Gabe Black <gabeblack@google.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/45687
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Commit-Queue: Gabe Black <gabeblack@chromium.org>
Tested-by: Gabe Black <gabeblack@chromium.org>

firmware/lib/include/bmpblk_font.h

@@ -39,8 +39,6 @@
 
 #include "bmpblk_header.h"
 
-__pragma(pack(push, 1))  /* Support packing for MSVC. */
-
 #define FONT_SIGNATURE      "FONT"
 #define FONT_SIGNATURE_SIZE 4
 
@@ -62,6 +60,4 @@ typedef struct FontArrayEntryHeader {
 	 */
 } __attribute__((packed)) FontArrayEntryHeader;
 
-__pragma(pack(pop)) /* Support packing for MSVC. */
-
 #endif  /* VBOOT_REFERENCE_BMPBLK_FONT_H_ */

firmware/lib/include/rollback_index.h

@@ -18,8 +18,6 @@
 
 /* Structure definitions for TPM spaces */
 
-__pragma(pack(push, 1)) /* Support packing for MSVC. */
-
 /* Kernel space - KERNEL_NV_INDEX, locked with physical presence. */
 #define ROLLBACK_SPACE_KERNEL_VERSION 2
 #define ROLLBACK_SPACE_KERNEL_UID 0x4752574C  /* 'GRWL' */
@@ -68,8 +66,6 @@ typedef struct RollbackSpaceFirmware {
 	uint8_t crc8;
 } __attribute__((packed)) RollbackSpaceFirmware;
 
-__pragma(pack(pop)) /* Support packing for MSVC. */
-
 /* All functions return TPM_SUCCESS (zero) if successful, non-zero if error */
 
 /*