From b3911e8eeffe128187fc03c0e5faaa8dabe6752f Mon Sep 17 00:00:00 2001 From: Vincent Palatin Date: Thu, 22 Oct 2015 09:03:42 -0700 Subject: [PATCH] ryu: do not pull EN_PP3300 Modify the former workaround for board revisions missing an external pull-up to 1.8V on EN_PP3300 : the 100kOhm resistor between GPE13 and EN_PP3300 is still stuffed even on boards which don't need the workaround, so tri-state the pin to avoid driving the net. Signed-off-by: Vincent Palatin BRANCH=smaug BUG=chrome-os-partner:46799 TEST=probed EN_3300 voltage level. Change-Id: I48f2b2fa9a716cdbe07fbc8a006ba4d3fcfaa63d Reviewed-on: https://chromium-review.googlesource.com/307868 Reviewed-by: Todd Broch Reviewed-by: Gwendal Grignou Commit-Queue: Vincent Palatin Tested-by: Vincent Palatin (cherry picked from commit 53e49d6d6541183349bb7267fa5ec2b1db250d99) Reviewed-on: https://chromium-review.googlesource.com/308514 Commit-Ready: Vincent Palatin --- board/ryu/gpio.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/ryu/gpio.inc b/board/ryu/gpio.inc index 5871bd9271..a81d6d6c59 100644 --- a/board/ryu/gpio.inc +++ b/board/ryu/gpio.inc @@ -51,7 +51,7 @@ GPIO(PMIC_WARM_RESET_L, PIN(E, 4), GPIO_ODR_HIGH) * This GPIO is used to pull it up through an external 100kOhm. * EN_PP3300 is still controlled by PMIC though. */ -GPIO(EN_PP3300_RSVD, PIN(E, 13), GPIO_OUT_LOW) +GPIO(EN_PP3300_RSVD, PIN(E, 13), GPIO_ODR_HIGH) /* sensor temp output and PMIC reset input */ GPIO(PMIC_THERM_L, PIN(B, 8), GPIO_ODR_HIGH) GPIO(VBUS_SENSE, PIN(A, 0), GPIO_ANALOG)