From b3cd77eca5b39f6e19add397a7ddf01125c0134e Mon Sep 17 00:00:00 2001 From: Shawn Nematbakhsh Date: Thu, 10 Sep 2015 11:44:32 -0700 Subject: [PATCH] glados: Power-off PP1800_DX_AUDIO during S3 Save .2mA during S3 by de-powering PP1800_DX_AUDIO. BUG=chrome-os-partner:45091 TEST=Boot glados, go to S3 and verify PP1800_DX_AUDIO_EN is low. Go to S0 and verify PP1800_DX_AUDIO_EN is high. Boot with locked descriptor and try to overwrite descriptor region, verify that flashrom errors out. BRANCH=None Signed-off-by: Shawn Nematbakhsh Change-Id: If05142ad7c39847a8e94e26d047daa2bc71f0ca5 Reviewed-on: https://chromium-review.googlesource.com/299003 Commit-Ready: Shawn N Tested-by: Shawn N Reviewed-by: Alec Berg --- board/glados/board.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/glados/board.c b/board/glados/board.c index b7f3f07690..100d7db209 100644 --- a/board/glados/board.c +++ b/board/glados/board.c @@ -329,7 +329,6 @@ DECLARE_DEFERRED(enable_input_devices); /* Called on AP S5 -> S3 transition */ static void board_chipset_startup(void) { - gpio_set_level(GPIO_PP1800_DX_AUDIO_EN, 1); hook_call_deferred(enable_input_devices, 0); } DECLARE_HOOK(HOOK_CHIPSET_STARTUP, board_chipset_startup, HOOK_PRIO_DEFAULT); @@ -337,7 +336,6 @@ DECLARE_HOOK(HOOK_CHIPSET_STARTUP, board_chipset_startup, HOOK_PRIO_DEFAULT); /* Called on AP S3 -> S5 transition */ static void board_chipset_shutdown(void) { - gpio_set_level(GPIO_PP1800_DX_AUDIO_EN, 0); hook_call_deferred(enable_input_devices, 0); } DECLARE_HOOK(HOOK_CHIPSET_SHUTDOWN, board_chipset_shutdown, HOOK_PRIO_DEFAULT); @@ -345,6 +343,7 @@ DECLARE_HOOK(HOOK_CHIPSET_SHUTDOWN, board_chipset_shutdown, HOOK_PRIO_DEFAULT); /* Called on AP S3 -> S0 transition */ static void board_chipset_resume(void) { + gpio_set_level(GPIO_PP1800_DX_AUDIO_EN, 1); gpio_set_level(GPIO_PP1800_DX_SENSOR_EN, 1); } DECLARE_HOOK(HOOK_CHIPSET_RESUME, board_chipset_resume, HOOK_PRIO_DEFAULT); @@ -352,6 +351,7 @@ DECLARE_HOOK(HOOK_CHIPSET_RESUME, board_chipset_resume, HOOK_PRIO_DEFAULT); /* Called on AP S0 -> S3 transition */ static void board_chipset_suspend(void) { + gpio_set_level(GPIO_PP1800_DX_AUDIO_EN, 0); gpio_set_level(GPIO_PP1800_DX_SENSOR_EN, 0); } DECLARE_HOOK(HOOK_CHIPSET_SUSPEND, board_chipset_suspend, HOOK_PRIO_DEFAULT);