From b4e6b8eef9679b0a58e521fabd35a6eec2d64b70 Mon Sep 17 00:00:00 2001 From: Daisuke Nojiri Date: Wed, 13 Dec 2017 16:09:00 -0800 Subject: [PATCH] Fizz: Remove power control of V3P3_USBPD PU62 used to be used to turn on power to PS8751 but it's been removed. PS8751 is powered directly from PP3300_EC. So, EC doesn't need to enable it. BUG=b:65212601 BRANCH=none TEST=On Kench EVT SKU5, verify type-c port is powered. Change-Id: I2a1ce28efe09212a4ce7e7b57c0560e42e137cec Signed-off-by: Daisuke Nojiri Reviewed-on: https://chromium-review.googlesource.com/826256 Reviewed-by: Aaron Durbin --- board/fizz/board.c | 9 ++------- board/fizz/gpio.inc | 3 --- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/board/fizz/board.c b/board/fizz/board.c index 5ae19c6137..c15d171ed8 100644 --- a/board/fizz/board.c +++ b/board/fizz/board.c @@ -221,14 +221,9 @@ void board_tcpc_init(void) { int port, reg; - /* Only reset TCPC if not sysjump */ - if (!system_jumped_to_this_image()) { - /* Power on PS8751 */ - gpio_set_level(GPIO_PP3300_USB_PD, 1); - /* TODO(crosbug.com/p/61098): How long do we need to wait? */ - msleep(10); + /* Only reset TCPC in RO boot. */ + if (!system_jumped_to_this_image()) board_reset_pd_mcu(); - } /* * Wake up PS8751. If PS8751 remains in low power mode after sysjump, diff --git a/board/fizz/gpio.inc b/board/fizz/gpio.inc index c1b3be59c7..f28d550e84 100644 --- a/board/fizz/gpio.inc +++ b/board/fizz/gpio.inc @@ -47,9 +47,6 @@ GPIO(POWER_RATE, PIN(7, 1), GPIO_INPUT) /* High: i3/5/7. Low: Celeron */ /* Fizz specific pins */ GPIO(LAN_PWR_EN, PIN(8, 3), GPIO_OUT_HIGH) /* Ethernet power enabled */ -/* TODO(crosbug.com/p/61098): Make use of these GPIOs */ -GPIO(PP3300_USB_PD, PIN(6, 7), GPIO_OUTPUT) - GPIO(PP5000_DX_NFC, PIN(1, 5), GPIO_OUTPUT) GPIO(PP3300_DX_CAM, PIN(1, 0), GPIO_OUT_HIGH)