From ba81b5ef8638daf0ce22f7fef16a5995f286c450 Mon Sep 17 00:00:00 2001 From: Vincent Palatin Date: Fri, 22 May 2015 17:41:32 -0700 Subject: [PATCH] ryu: remove the pull-up on ACOK it was not needed before, it's now harmful for the new VBUS detection circuit on EVT2. Signed-off-by: Vincent Palatin BRANCH=none BUG=none TEST=on Ryu P6 reworked with the new VBUS detection circuit, probed voltages and did "gpioget CHGR_ACOK" with type-C unplugged. Change-Id: I1d99f249c1949aa35f98a896e7ac8ee019295e19 Reviewed-on: https://chromium-review.googlesource.com/273006 Trybot-Ready: Vincent Palatin Commit-Queue: Vincent Palatin Tested-by: Vincent Palatin Reviewed-by: Vincent Palatin --- board/ryu/gpio.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/ryu/gpio.inc b/board/ryu/gpio.inc index d7063ed653..e65e7a0186 100644 --- a/board/ryu/gpio.inc +++ b/board/ryu/gpio.inc @@ -6,7 +6,7 @@ */ /* Interrupts */ -GPIO_INT(CHGR_ACOK, D, 4, GPIO_INT_BOTH | GPIO_PULL_UP, vbus_evt) +GPIO_INT(CHGR_ACOK, D, 4, GPIO_INT_BOTH, vbus_evt) GPIO_INT(POWER_BUTTON_L, C, 13, GPIO_INT_BOTH, power_button_interrupt) /* active high, the name is for compatibility with existing code */ GPIO_INT(USBC_BC12_INT_L, D, 11, GPIO_INT_FALLING | GPIO_PULL_UP, usb_evt) GPIO_INT(LID_OPEN, E, 1, GPIO_INT_BOTH | GPIO_PULL_UP, lid_interrupt)