From bc3d04edd4f2eb83a3d062c664174ed845097dd3 Mon Sep 17 00:00:00 2001
From: Vadim Bendebury <vbendeb@chromium.org>
Date: Mon, 31 Jul 2017 20:16:46 -0700
Subject: [PATCH] signer: refactor to use program name variable

Instead of invoking $(basename $0) multiple times, cache it in a
variable.

BRANCH=none
BUG=none
TEST=verified that the script still reports proper name when printing
      error messages.

Change-Id: Iabdf40592cb4cecc975a48d93169f46614ce84c6
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/597119
Reviewed-by: Caveh Jalali <caveh@google.com>
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
---
 util/signer/create_released_image.sh | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/util/signer/create_released_image.sh b/util/signer/create_released_image.sh
index 6a4273662c..21598e616b 100755
--- a/util/signer/create_released_image.sh
+++ b/util/signer/create_released_image.sh
@@ -109,15 +109,17 @@ prepare_image() {
 }
 
 # Execution starts here ===========================
+ME="$(basename $0)"
+
 if [ -z "${CROS_WORKON_SRCROOT}" ]; then
- echo "$(basename $0): This script must run inside Chrome OS chroot" >&2
+ echo "${ME}: This script must run inside Chrome OS chroot" >&2
   exit 1
 fi
 
 SCRIPT_ROOT="${CROS_WORKON_SRCROOT}/src/scripts"
 . "${SCRIPT_ROOT}/build_library/build_common.sh" || exit 1
 
-TMPD="$(mktemp -d /tmp/$(basename $0).XXXXX)"
+TMPD="$(mktemp -d /tmp/${ME}.XXXXX)"
 trap "/bin/rm -rf ${TMPD}" SIGINT SIGTERM EXIT
 
 EC_ROOT="${CROS_WORKON_SRCROOT}/src/platform/ec"
@@ -134,7 +136,7 @@ Consists of three fields separated by colon: <RLZ>:<hex mask>:<hex flags>"
 # error return values.
 set -e
 
-FLAGS_HELP="usage: $(basename $0) [flags] <blobs>
+FLAGS_HELP="usage: ${ME} [flags] <blobs>
 
 blobs are:
   <prod RO A>.hex <prod RO B>.hex <dev RO A>.hex <dev RO B>.hex \