From c3aec01fb66f3f85a08ef697ffd8963eaca52471 Mon Sep 17 00:00:00 2001 From: Nick Sanders Date: Thu, 1 Sep 2016 19:13:26 -0700 Subject: [PATCH] sweetberry: remove superfluous gpios Sweetberry specifies UART pins as GPIOs, however this is not necessary for uart use. Let's remove these. UART4 is also dup'd with sweetberry's signal gpios, which is fixed with this CL. BUG=chromium:608039 TEST=boots BRANCH=None Change-Id: I81ee2351c0191ff5ec3d5fad37fe10866bf1ad32 Signed-off-by: Nick Sanders Reviewed-on: https://chromium-review.googlesource.com/380439 Reviewed-by: Bill Richardson --- board/sweetberry/gpio.inc | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/board/sweetberry/gpio.inc b/board/sweetberry/gpio.inc index b559d8b875..cfab7fc1f3 100644 --- a/board/sweetberry/gpio.inc +++ b/board/sweetberry/gpio.inc @@ -41,12 +41,15 @@ GPIO(I2C3_SDA, PIN(B, 4), GPIO_INPUT) GPIO(FMPI2C_SCL, PIN(C, 6), GPIO_INPUT) GPIO(FMPI2C_SDA, PIN(C, 7), GPIO_INPUT) -/* USART3 TX/RX */ -GPIO(MCU_UART3_TX, PIN(C, 10), GPIO_INPUT) -GPIO(MCU_UART3_RX, PIN(C, 11), GPIO_INPUT) -/* USART4 TX/RX */ -GPIO(MCU_UART4_TX, PIN(A, 0), GPIO_INPUT) -GPIO(MCU_UART4_RX, PIN(A, 1), GPIO_INPUT) +/* These pin assignments aren't used as GPIO. Let's note them here + * for readability but not initialize them. + * USART3 TX/RX + * GPIO(MCU_UART3_TX, PIN(C, 10), GPIO_INPUT) + * GPIO(MCU_UART3_RX, PIN(C, 11), GPIO_INPUT) + * USART4 TX/RX + * GPIO(MCU_UART4_TX, PIN(A, 0), GPIO_INPUT) + * GPIO(MCU_UART4_RX, PIN(A, 1), GPIO_INPUT) + */ /* USB pins */ GPIO(USB_FS_DM, PIN(A, 11), GPIO_INPUT)