From c49d32a265ea76d9af55ccbcbda90e27748de1a3 Mon Sep 17 00:00:00 2001 From: Nicolas Boichat Date: Wed, 25 Oct 2017 10:03:47 +0800 Subject: [PATCH] poppy: Update LED behaviour According to spec, blink when charge is lower than 10%. BRANCH=none BUG=b:37970194 TEST=Flash soraka, LED behave as intended. Change-Id: Ifaab76bb1a92f060eb81f06deab84b45509ad40d Signed-off-by: Nicolas Boichat Reviewed-on: https://chromium-review.googlesource.com/737170 Reviewed-by: Furquan Shaikh --- board/poppy/led.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/board/poppy/led.c b/board/poppy/led.c index 0d43497c23..0c2d7f1832 100644 --- a/board/poppy/led.c +++ b/board/poppy/led.c @@ -102,12 +102,8 @@ static void board_led_set_battery(void) set_active_port_color(LED_AMBER); break; case PWR_STATE_DISCHARGE: - /* - * TODO(b/37970194): Do we really want to blink on low battery? - * If yes, what's the threshold? In S0 only? - */ if (led_auto_control_is_enabled(EC_LED_ID_LEFT_LED)) { - if (charge_get_percent() < 12) + if (charge_get_percent() <= 10) side_led_set_color(0, (battery_ticks & 0x4) ? LED_WHITE : LED_OFF); else