From c557a283bbc7b17a7159e1c8c013443e422f89ca Mon Sep 17 00:00:00 2001 From: Todd Broch Date: Tue, 4 Nov 2014 05:16:06 -0800 Subject: [PATCH] pd: Remove BMC support bit from message header. Initial versions of the USB Power Delivery (v0.7) had this bit defined but in later versions its been removed and should be zero. BRANCH=samus BUG=none TEST=manual, capture message header with twinkie and see that message header <15> is no longer asserted. Change-Id: Ib3e099322b681a49a75b07e1ff929083c71eb44a Signed-off-by: Todd Broch Reviewed-on: https://chromium-review.googlesource.com/227421 Reviewed-by: Vincent Palatin Reviewed-by: Alec Berg Commit-Queue: Alec Berg Tested-by: Alec Berg --- include/usb_pd.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/include/usb_pd.h b/include/usb_pd.h index 27e3081dd8..0d667ec517 100644 --- a/include/usb_pd.h +++ b/include/usb_pd.h @@ -580,9 +580,6 @@ enum pd_data_msg_type { #define PD_REV10 0 #define PD_REV20 1 -/* BMC-supported bit : we are using the baseband variant of the protocol */ -#define PD_BMC_SUPPORTED (1 << 15) - /* Port role */ #define PD_ROLE_SINK 0 #define PD_ROLE_SOURCE 1 @@ -594,8 +591,7 @@ enum pd_data_msg_type { #define PD_HEADER(type, prole, drole, id, cnt) \ ((type) | (PD_REV20 << 6) | \ ((drole) << 5) | ((prole) << 8) | \ - ((id) << 9) | ((cnt) << 12) | \ - PD_BMC_SUPPORTED) + ((id) << 9) | ((cnt) << 12)) #define PD_HEADER_CNT(header) (((header) >> 12) & 7) #define PD_HEADER_TYPE(header) ((header) & 0xF)