From cf43a3b7beb13996e0600605c219d05f562de187 Mon Sep 17 00:00:00 2001 From: Randall Spangler Date: Tue, 28 Jan 2014 13:14:51 -0800 Subject: [PATCH] rambi: Enable low-power idle This should reduce EC power consumption in S3 and S5. BUG=chrome-os-partner:25377 BRANCH=baytrail TEST=make sure jtag is not active (not running openocd via servo) boot system; suspend system wait 60 seconds; should see "Disabling console in deep sleep" type on console; should still allow typing wait 60 seconds; press spacebar; should still resume from suspend Change-Id: I47e33e158c1b90077f944a6af4374f39efa68d94 Signed-off-by: Randall Spangler Reviewed-on: https://chromium-review.googlesource.com/184165 Reviewed-by: Alec Berg --- board/rambi/board.h | 1 + include/config.h | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/board/rambi/board.h b/board/rambi/board.h index bebe44e570..95736b2e09 100644 --- a/board/rambi/board.h +++ b/board/rambi/board.h @@ -29,6 +29,7 @@ #define CONFIG_KEYBOARD_IRQ_GPIO GPIO_KBD_IRQ_L #define CONFIG_KEYBOARD_PROTOCOL_8042 #define CONFIG_LED_COMMON +#define CONFIG_LOW_POWER_IDLE #undef CONFIG_PECI #define CONFIG_POWER_BUTTON #define CONFIG_POWER_BUTTON_X86 diff --git a/include/config.h b/include/config.h index 58f68e2b33..46b6faef17 100644 --- a/include/config.h +++ b/include/config.h @@ -508,6 +508,12 @@ * Low power idle options. These are disabled by default and all boards that * want to use low power idle must define it. When using the LFIOSC, the low * frequency clock will be used to conserve even more power when possible. + * + * GPIOs which need to trigger interrupts in low power idle must specify the + * GPIO_INT_DSLEEP flag in gpio_list[]. + * + * Note that for some processors (e.g. LM4), an active JTAG connection will + * prevent the EC from using low-power idle. */ #undef CONFIG_LOW_POWER_IDLE #undef CONFIG_LOW_POWER_USE_LFIOSC