From d574f070c52f913790dd0c69b178de3dbeac3078 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Thu, 12 Mar 2015 02:26:19 -0400 Subject: [PATCH] avoid git status When trying to build out-of-tree, running `git status` will attempt to write to the .git/ dir which causes a sandbox violation. Since this code doesn't seem to actually do anything, drop it. BUG=chromium:466499 TEST=precq still passes TEST=build now passes when building out of tree TEST=`./scripts/getversion.sh` produces good output with clean & dirty trees BRANCH=None Change-Id: Ia722fedef692876ffc87109b3a1d2e4a76235532 Reviewed-on: https://chromium-review.googlesource.com/259541 Trybot-Ready: Mike Frysinger Reviewed-by: Bill Richardson Commit-Queue: Mike Frysinger Tested-by: Mike Frysinger --- scripts/getversion.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/getversion.sh b/scripts/getversion.sh index b6f2bd4c45..d505579f2b 100755 --- a/scripts/getversion.sh +++ b/scripts/getversion.sh @@ -21,8 +21,6 @@ if ghash=$(git rev-parse --short --verify HEAD 2>/dev/null); then fi # avoid putting the -dirty attribute if only the timestamp # changed - git status > /dev/null 2>&1 - dirty=$(sh -c "[ '$(git diff-index --name-only HEAD)' ] \ && echo '-dirty'") ver="${ver_major}.${ver_branch}.${numcommits}-${ghash}${dirty}"