From de6825d3ff196d1a5ccb34aa5575863bd946bf55 Mon Sep 17 00:00:00 2001 From: Tom Wai-Hong Tam Date: Fri, 27 Apr 2018 13:59:46 -0700 Subject: [PATCH] cheza: Remove internal pull-up for the BATT_PRES_ODL pin There is an external pull-up for the BATT_PRES_ODL signal. BRANCH=none BUG=b:74395451 TEST=Verified the BATT_PRES_ODL value when battery plugged or not. Change-Id: Ief10820290c204cd0a965081165df9f64ce1bb34 Signed-off-by: Tom Wai-Hong Tam Reviewed-on: https://chromium-review.googlesource.com/1035450 Commit-Ready: Wai-Hong Tam Tested-by: Wai-Hong Tam Reviewed-by: Vincent Palatin --- board/cheza/gpio.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/cheza/gpio.inc b/board/cheza/gpio.inc index 302aff7f95..8f056073b7 100644 --- a/board/cheza/gpio.inc +++ b/board/cheza/gpio.inc @@ -28,7 +28,7 @@ GPIO(SYS_RST_L, PIN(0, 2), GPIO_ODR_HIGH) /* PMIC reset trigger */ GPIO(PS_HOLD, PIN(D, 4), GPIO_INPUT) /* Indicate when AP triggers reset/shutdown */ GPIO(ENTERING_RW, PIN(E, 1), GPIO_OUT_LOW) /* EC_ENTERING_RW: Indicate when EC is entering RW code */ GPIO(CCD_MODE_ODL, PIN(E, 3), GPIO_INPUT) /* Case Closed Debug Mode */ -GPIO(BATT_PRES_ODL, PIN(E, 5), GPIO_INPUT | GPIO_PULL_UP) /* EC_BATT_PRES_ODL: Battery Present */ +GPIO(BATT_PRES_ODL, PIN(E, 5), GPIO_INPUT) /* EC_BATT_PRES_ODL: Battery Present */ GPIO(PMIC_FAULT_L, PIN(7, 6), GPIO_INPUT) /* Any PMIC fault? */ GPIO(PMIC_KPD_PWR_ODL, PIN(D, 6), GPIO_OUT_HIGH) /* TP10, rework jumps to PMIC power button */ GPIO(AP_EC_INT_L, PIN(A, 2), GPIO_INPUT) /* Interrupt line between AP and EC */