From e0b4a3d205d4a58605be86804a0b607dadeacb18 Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Wed, 7 Jun 2017 17:13:48 +0000 Subject: [PATCH] Revert "eve: Set VCCIO rail to 0.85 and disable low power" This reverts commit 9565b8ba06633e840fe9db356973ea21bba68c49. Reason for revert: This is causing memory test failure under specific reset conditions that is triggered by a specific FAFT test. BUG=b:35581264 BRANCH=eve TEST=pass FAFT test firmware_FwScreenPressPower Original change's description: > eve: Set VCCIO rail to 0.85 and disable low power > > Set the VCCIO rail to 0.85V where it should be for Y-series parts > instead of forcing it to 1.0V. The EDS is pretty clear that pushing > this voltage higher on Y-series parts will have significant power penalty. > (up to 250mW at 0.95V) > > We also don't want this rail dropping in low power mode, which shoudln't > be happening as S0ix is disabled so SLP_S0 shouldn't assert, but just in > case disable this as well. > > BUG=b:35587084 > BRANCH=eve > TEST=stress testing on Eve EVT units > > Change-Id: I5535fe0d894f283a8d453d61101dfeb6b9287b7c > Signed-off-by: Duncan Laurie > Reviewed-on: https://chromium-review.googlesource.com/525836 > Reviewed-by: Todd Broch Change-Id: Ie60ad319421c00df5bf41b9eca03047a37defb88 Signed-off-by: Duncan Laurie Reviewed-on: https://chromium-review.googlesource.com/527513 Reviewed-by: Scott Collyer --- board/eve/board.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/board/eve/board.c b/board/eve/board.c index 8ef4746692..85f82b6932 100644 --- a/board/eve/board.c +++ b/board/eve/board.c @@ -358,9 +358,10 @@ static void board_pmic_init(void) /* * Set V085ACNT / V0.85A Control Register: - * Nominal output = 0.85V. + * Lower power mode = 0.7V. + * Nominal output = 1.0V. */ - i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, 0x38, 0x2a); + i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, 0x38, 0x7a); /* VRMODECTRL - disable low-power mode for all rails */ i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, 0x3b, 0x1f);