From e1d255118e493e41d7ca16e8315a70856d4b4643 Mon Sep 17 00:00:00 2001 From: Ravi Chandra Sadineni Date: Tue, 7 Feb 2017 17:12:53 +0000 Subject: [PATCH] Revert "snappy: led: blink power led in once every 4 secs." This reverts commit 21e2878a72000788d3c7e7c8e96e0cf9bb0edc08. Reason for revert: OEMS have flexibility over the LED requirements. Original change's description: > snappy: led: blink power led in once every 4 secs. > > Currently the led blinks once sec every 2 secs. But > as per the hardware reuqirements it should be one sec every 4 > secs. > > BRANCH=none > BUG=chrome-os-partner:62655 > TEST=Enter s0ix, s3 manually and make sure it blinks once > every 4 secs. > Signed-off-by: Ravi Chandra Sadineni > > Change-Id: I3ade6c5789c172c66dfb022cd12439752d96addc > Reviewed-on: https://chromium-review.googlesource.com/437601 > Commit-Ready: Ravi Chandra Sadineni > Tested-by: Ravi Chandra Sadineni > Reviewed-by: Aaron Durbin > TBR=bleung@chromium.org,adurbin@chromium.org,adurbin@google.com,moch@google.com,moch@chromium.org,ravisadineni@chromium.org,philipchen@chromium.org,bleung@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chrome-os-partner:62655 Change-Id: I81307382774b643af9c2ae2b1682e0e5498b1472 Reviewed-on: https://chromium-review.googlesource.com/439364 Commit-Ready: Ravi Chandra Sadineni Tested-by: Ravi Chandra Sadineni Reviewed-by: Aaron Durbin --- board/snappy/led.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/snappy/led.c b/board/snappy/led.c index 2557079e3c..1850317114 100644 --- a/board/snappy/led.c +++ b/board/snappy/led.c @@ -156,7 +156,7 @@ static void led_set_battery(void) static void led_set_power(void) { - static unsigned int power_tick; + static int power_tick; power_tick++; @@ -165,7 +165,7 @@ static void led_set_power(void) else if (chipset_in_state(CHIPSET_STATE_SUSPEND | CHIPSET_STATE_STANDBY)) led_set_color_power( - ((power_tick & 0xf) >= 0xc) ? LED_WHITE : LED_OFF); + (power_tick & 0x4) ? LED_WHITE : LED_OFF); else led_set_color_power(LED_OFF); }