From ea1a8699e96425806abdd532d04da254ae093f6e Mon Sep 17 00:00:00 2001 From: Aseda Aboagye Date: Thu, 27 Oct 2016 16:53:13 -0700 Subject: [PATCH] kevin: Remove PD related TODOs. It was confirmed that these values were correct. BUG=chrome-os-partner:59074 BUG=chrome-os-partner:59075 BRANCH=gru TEST=make -j buildall Change-Id: I8c63d563515c1fdcbd9f83203c193ba09f8f3447 Signed-off-by: Aseda Aboagye Reviewed-on: https://chromium-review.googlesource.com/404709 Commit-Ready: Aseda Aboagye Tested-by: Aseda Aboagye Reviewed-by: Shawn N --- board/kevin/board.h | 4 ---- board/kevin/usb_pd_policy.c | 1 - 2 files changed, 5 deletions(-) diff --git a/board/kevin/board.h b/board/kevin/board.h index 05fc660f81..e55e6b1057 100644 --- a/board/kevin/board.h +++ b/board/kevin/board.h @@ -130,10 +130,6 @@ #define PD_MAX_CURRENT_MA 3000 #define PD_MAX_VOLTAGE_MV 20000 -/* - * TODO(crosbug.com/p/59074): determine the following board specific type-C - * power constants - */ #define PD_POWER_SUPPLY_TURN_ON_DELAY 30000 /* us */ #define PD_POWER_SUPPLY_TURN_OFF_DELAY 50000 /* us */ #define PD_VCONN_SWAP_DELAY 5000 /* us */ diff --git a/board/kevin/usb_pd_policy.c b/board/kevin/usb_pd_policy.c index e81659306c..4f145dc1ad 100644 --- a/board/kevin/usb_pd_policy.c +++ b/board/kevin/usb_pd_policy.c @@ -25,7 +25,6 @@ #define PDO_FIXED_FLAGS (PDO_FIXED_DUAL_ROLE | PDO_FIXED_DATA_SWAP |\ PDO_FIXED_COMM_CAP) -/* TODO(crosbug.com/p/59075): fill in correct source and sink capabilities */ const uint32_t pd_src_pdo[] = { PDO_FIXED(5000, 1500, PDO_FIXED_FLAGS), };