scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-11-24 02:05:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make BIOS screens warn when GBB.flags is nonzero.

Browse Source 
BUG=chrome-os-partner:5919
TEST=manual

Until the factory flow has completed, BIOS screens should display a warning
message about GBB.flags. This message should disappear once the flags field
is zero.

You can see the state of the GBB flags in a particular BIOS image using

  gbb_utility -g --flags BIOS.bin

And set it with

  gbb_utility -s --flags=VALUE BIOS.bin NEWBIOS.bin

Change-Id: I15d336bda571978ece0a9744f19d80f0ae385fb1
Reviewed-on: http://gerrit.chromium.org/gerrit/7719
Tested-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
This commit is contained in:
Bill Richardson
2011-09-14 10:42:54 -07:00
parent 518d4f39b4
commit ec35beb128
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
firmware/lib/vboot_display.c
View File

@@ -308,6 +308,17 @@ VbError_t VbDisplayScreenFromGBB(VbCommonParams* cparams, uint32_t screen,
/* Successful if all bitmaps displayed */ /* Successful if all bitmaps displayed */
retval = VBERROR_SUCCESS; retval = VBERROR_SUCCESS;
/* If GBB flags is nonzero, complain because that's something that the
* factory MUST fix before shipping. We only have to do this here, because
* it's obvious that something is wrong if we're not displaying screens from
* the GBB.
*/
if (gbb->major_version == GBB_MAJOR_VER && gbb->minor_version >= 1 &&
(gbb->flags != 0)) {
(void)VbExDisplayDebugInfo("GBB.flags is nonzero");
}
VbDisplayScreenFromGBB_exit: VbDisplayScreenFromGBB_exit:
/* Free the bitmap data copy */ /* Free the bitmap data copy */