From f1e6af516c87623f475900f8fc85cb9c40668092 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Thu, 5 Oct 2017 15:35:23 +0200 Subject: [PATCH] util/ectool.c: Make sure device_name is NUL terminated BRANCH=none BUG=none TEST=none Found-by: Coverity Scan #144116 Change-Id: I9ec030c1a3820af7d08c2a83e3c1f4c3ee7a3f0a Signed-off-by: Patrick Georgi Reviewed-on: https://chromium-review.googlesource.com/702302 Commit-Ready: Patrick Georgi Tested-by: Patrick Georgi Reviewed-by: Chris Ching --- util/ectool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/ectool.c b/util/ectool.c index 0fecb6db83..ff41538b44 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -7337,7 +7337,7 @@ int main(int argc, char *argv[]) const struct command *cmd; int dev = 0; int interfaces = COMM_ALL; - char device_name[40] = CROS_EC_DEV_NAME; + char device_name[41] = CROS_EC_DEV_NAME; int rv = 1; int parse_error = 0; char *e; @@ -7374,6 +7374,7 @@ int main(int argc, char *argv[]) break; case OPT_NAME: strncpy(device_name, optarg, 40); + device_name[40] = '\0'; break; } }