From fdfa29b1678cd04ef15f62d1b5df7c828204dd91 Mon Sep 17 00:00:00 2001 From: Bill Richardson Date: Wed, 3 Aug 2016 16:42:50 -0700 Subject: [PATCH] Cr50: The battery-present gpio is active low The input should be active low, not active high. BUG=chrome-os-partner:49959 BRANCH=none TEST=manual Remove and reattach the battery. "gpioget BATT_PRES_L" shows the GPIO value changing appropriately. Change-Id: I7d513471f6ab5e7e8cd0e601148915697fa9162a Signed-off-by: Bill Richardson Reviewed-on: https://chromium-review.googlesource.com/366134 Reviewed-by: Vadim Bendebury --- board/cr50/gpio.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/board/cr50/gpio.inc b/board/cr50/gpio.inc index 8234e80017..189103c476 100644 --- a/board/cr50/gpio.inc +++ b/board/cr50/gpio.inc @@ -47,8 +47,8 @@ GPIO(SYS_RST_L_OUT, PIN(0, 4), GPIO_INPUT) * it decided instead. The pullup is on the EC's side. */ GPIO(CCD_MODE_L, PIN(0, 5), GPIO_ODR_HIGH) -/* Battery has a 10K pulldown on its side. We provide the pullup. */ -GPIO(BATT_PRES, PIN(0, 6), GPIO_INPUT) +/* Battery present signal is active low */ +GPIO(BATT_PRES_L, PIN(0, 6), GPIO_INPUT) /* GPIOs used to tristate the SPI bus */ GPIO(SPI_MOSI, PIN(0, 7), GPIO_INPUT) @@ -84,7 +84,7 @@ PINMUX(GPIO(AP_WP_L), M3, 0) PINMUX(GPIO(SYS_RST_L_IN), M0, DIO_WAKE_FALLING) PINMUX(GPIO(SYS_RST_L_OUT), M0, DIO_INPUT) PINMUX(GPIO(CCD_MODE_L), M1, DIO_INPUT) -PINMUX(GPIO(BATT_PRES), M2, 0) +PINMUX(GPIO(BATT_PRES_L), M2, 0) PINMUX(GPIO(STRAP0), A1, DIO_INPUT) /* UARTs */