From fe89f7f5c7104167c46fca5f9f00508f09b1eb99 Mon Sep 17 00:00:00 2001 From: Sam Hurst Date: Wed, 22 Feb 2017 09:16:15 -0800 Subject: [PATCH] ec:Correct ACPI host commands All host commands must be 4-digit uppercase hex digits. The current ACPI host commands are defined as follows: #define EC_CMD_ACPI_READ 0x80 #define EC_CMD_ACPI_WRITE 0x81 #define EC_CMD_ACPI_BURST_ENABLE 0x82 #define EC_CMD_ACPI_BURST_DISABLE 0x83 #define EC_CMD_ACPI_QUERY_EVENT 0x84 BUG=chrome-os-partner:63190 TEST=make -j buildall 100bd248 R __host_cmd_0x00000x0080 100bd254 R __host_cmd_0x00000x0081 100bd260 R __host_cmd_0x00000x0082 100bd26c R __host_cmd_0x00000x0083 100bd278 R __host_cmd_0x00000x0084 BRANCH=none Change-Id: I48ad9c179454eb237018377023bae10a79c7799e Reviewed-on: https://chromium-review.googlesource.com/445809 Commit-Ready: Sam Hurst Tested-by: Sam Hurst Reviewed-by: Randall Spangler --- include/ec_commands.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/ec_commands.h b/include/ec_commands.h index c65d7f9d0c..cf3134cd66 100644 --- a/include/ec_commands.h +++ b/include/ec_commands.h @@ -205,7 +205,7 @@ * - Wait for EC_LPC_CMDR_DATA bit to set * - Read value from EC_LPC_ADDR_ACPI_DATA */ -#define EC_CMD_ACPI_READ 0x80 +#define EC_CMD_ACPI_READ 0x0080 /* * ACPI Write Embedded Controller @@ -220,7 +220,7 @@ * - Wait for EC_LPC_CMDR_PENDING bit to clear * - Write value to EC_LPC_ADDR_ACPI_DATA */ -#define EC_CMD_ACPI_WRITE 0x81 +#define EC_CMD_ACPI_WRITE 0x0081 /* * ACPI Burst Enable Embedded Controller @@ -229,7 +229,7 @@ * commands back-to-back. While in this mode, writes to mapped multi-byte * data are locked out to ensure data consistency. */ -#define EC_CMD_ACPI_BURST_ENABLE 0x82 +#define EC_CMD_ACPI_BURST_ENABLE 0x0082 /* * ACPI Burst Disable Embedded Controller @@ -237,7 +237,7 @@ * This disables burst mode on the EC and stops preventing EC writes to mapped * multi-byte data. */ -#define EC_CMD_ACPI_BURST_DISABLE 0x83 +#define EC_CMD_ACPI_BURST_DISABLE 0x0083 /* * ACPI Query Embedded Controller @@ -246,7 +246,7 @@ * sets the result code to the 1-based index of the bit (event 0x00000001 = 1, * event 0x80000000 = 32), or 0 if no event was pending. */ -#define EC_CMD_ACPI_QUERY_EVENT 0x84 +#define EC_CMD_ACPI_QUERY_EVENT 0x0084 /* Valid addresses in ACPI memory space, for read/write commands */