From ff11702c40a7bd88fa64444798c40731a09e4166 Mon Sep 17 00:00:00 2001 From: Jett Rink Date: Fri, 9 Feb 2018 08:16:00 -0700 Subject: [PATCH] grunt: Making control of SCI and SMI interrupt pins more clear BRANCH=none BUG=none TEST=none Change-Id: I82d0a68f192fdc339af8682b99781cb16802ac32 Signed-off-by: Jett Rink Reviewed-on: https://chromium-review.googlesource.com/911590 Reviewed-by: Edward Hill --- board/grunt/gpio.inc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/board/grunt/gpio.inc b/board/grunt/gpio.inc index f5e71ea87f..11f3b49dae 100644 --- a/board/grunt/gpio.inc +++ b/board/grunt/gpio.inc @@ -61,8 +61,11 @@ GPIO(I2C5_SDA, PIN(3, 6), GPIO_INPUT) /* EC_I2C_EEPROM_SDA and GPIO(I2C7_SCL, PIN(B, 3), GPIO_INPUT | GPIO_SEL_1P8V) /* EC_I2C_SENSOR_SCL */ GPIO(I2C7_SDA, PIN(B, 2), GPIO_INPUT | GPIO_SEL_1P8V) /* EC_I2C_SENSOR_SDA */ -GPIO(PCH_SCI_ODL, PIN(7, 6), GPIO_ODR_HIGH) -GPIO(PCH_SMI_ODL, PIN(C, 6), GPIO_ODR_HIGH) +/* + * The NPCX LPC driver configures and controls SCI and SMI, + * so PCH_SCI_ODL [PIN(7, 6)] and PCH_SMI_ODL [PIN(C, 6)] are + * not defined here as GPIOs. + */ GPIO(PCH_SLP_S0_L, PIN(A, 4), GPIO_INPUT) GPIO(EN_USB_A0_5V, PIN(6, 1), GPIO_OUT_LOW) /* Enable A0 5V Charging */