From fffc34706d2ce60678d0e3ef203d4639e18f7d39 Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Tue, 29 Nov 2016 13:51:55 -0800 Subject: [PATCH] eve: Set KBD_KS02 to pull-down when hibernating cr50 has an internal pull-down on this pin so the EC should match it to prevent leakage. BUG=chrome-os-partner:58666 BRANCH=none TEST=build and boot on eve and verify hibernate enter/exit Change-Id: I3eba0661211d356783c0c710f0d7d5fe11fd6c26 Signed-off-by: Duncan Laurie Reviewed-on: https://chromium-review.googlesource.com/415225 Reviewed-by: Scott Collyer --- board/eve/board.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/board/eve/board.c b/board/eve/board.c index 4cf049d88a..95196dee43 100644 --- a/board/eve/board.c +++ b/board/eve/board.c @@ -575,8 +575,10 @@ void board_hibernate_late(void) * while hibernating we want to enable GPIO_PULL_UP as well. */ gpio_set_flags_by_mask(0x2, 0x03, GPIO_INPUT | GPIO_PULL_UP); - gpio_set_flags_by_mask(0x1, 0xFF, GPIO_INPUT | GPIO_PULL_UP); + gpio_set_flags_by_mask(0x1, 0x7F, GPIO_INPUT | GPIO_PULL_UP); gpio_set_flags_by_mask(0x0, 0xE0, GPIO_INPUT | GPIO_PULL_UP); + /* KBD_KS02 needs to have a pull-down enabled to match cr50 */ + gpio_set_flags_by_mask(0x1, 0x80, GPIO_INPUT | GPIO_PULL_DOWN); } void board_hibernate(void)