mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2025-12-27 18:25:05 +00:00
c89ebdb66c
Allow to negotiate the packet command and responses to
whatever values the EC can support.
Set the buffer size including the necessary V3 header.
If the EC run v3 protocol with large packet support, but the kernel
does not have v3 support (3.10), we can not support sending or
receiving large commands.
Be aware that on 3.10, commands like ectool console will fail if
the EC wants to send command larger than the kernel can handle.
Copied kernel_version_ge from libusb-1.0.19/libusb/os/linux_usbfs.c.
BUG=chrome-os-partner:31989,chrome-os-partner:31660,chromium:454324,chrome-os-partner:39265
BRANCH=none
TEST=Build a special firmware to exchange 300 bytes.
Check ectool console works with the righ size.
Check that ectool is calling uname.
Check on Nyan_big: without change, "ectool version" crashes kernel. With
changes, "ectool version" works.
In conseuqence, it reverts commit be0bd9b835,
"ectool: Do not increase buffer size after probe max size from ec"
Change-Id: I54ffd43488ea81272f30789dc87a261085769fe0
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/274086
Reviewed-by: Shawn N <shawnn@chromium.org>
65 lines
1.8 KiB
C
65 lines
1.8 KiB
C
/* Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#ifndef __CROS_EC_MISC_UTIL_H
|
|
#define __CROS_EC_MISC_UTIL_H
|
|
|
|
/* Don't use a macro where an inline will do... */
|
|
static inline int MIN(int a, int b) { return a < b ? a : b; }
|
|
|
|
/**
|
|
* Write a buffer to the file.
|
|
*
|
|
* @param filename Target filename
|
|
* @param buf Buffer to write
|
|
* @param size Size of buffer in bytes
|
|
* @return non-zero if error
|
|
*/
|
|
int write_file(const char *filename, const char *buf, int size);
|
|
|
|
/**
|
|
* Read a file into a newly-allocated buffer.
|
|
*
|
|
* @param filename Source filename
|
|
* @param size Size of data in bytes will be stored here on success.
|
|
* @return A newly allocated buffer with the data, which must be freed with
|
|
* free() by the caller, or NULL if error.
|
|
*/
|
|
char *read_file(const char *filename, int *size);
|
|
|
|
/**
|
|
* Check if a string contains only printable characters.
|
|
*
|
|
* @param buf Null-terminated string to check
|
|
* @return non-zero if buf contains only printable characters; zero if not.
|
|
*/
|
|
int is_string_printable(const char *buf);
|
|
|
|
/**
|
|
* Get the versions of the command supported by the EC.
|
|
*
|
|
* @param cmd Command
|
|
* @param pmask Destination for version mask; will be set to 0 on
|
|
* error.
|
|
* @return 0 if success, <0 if error
|
|
*/
|
|
int ec_get_cmd_versions(int cmd, uint32_t *pmask);
|
|
|
|
/**
|
|
* Return non-zero if the EC supports the command and version
|
|
*
|
|
* @param cmd Command to check
|
|
* @param ver Version to check
|
|
* @return non-zero if command version supported; 0 if not.
|
|
*/
|
|
int ec_cmd_version_supported(int cmd, int ver);
|
|
|
|
/**
|
|
* Return 1 is the current kernel version is greater or equal to
|
|
* <major>.<minor>.<sublevel>
|
|
*/
|
|
int kernel_version_ge(int major, int minor, int sublevel);
|
|
#endif
|