scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-12-27 18:25:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
1016bdfd11ff4fae8e5a72e6561ca38b3d91b4cb
OpenCellular/common
History
Martin Roth fd355c219f common/i2c.c: Check that i2c port is always 0 or greater 
Previously, an assert was checking the port value after the
port value had been converted to the controller.  Instead, verify
that the value is not negative, and return if it is.

The if sequence generates much less code than the ASSERT, and protects
both paths.

Fixes coverity warning 141748: Negative array index read

42 files changed.
Total size change: -1248 bytes.
Average size change: -29 bytes.
These platforms increased in size:
lucid/RO/ec.RO.flat grew by 4 bytes: (64404 to 64408)
lucid/RW/ec.RW.flat grew by 20 bytes: (63996 to 64016)
pyro/RO/ec.RO.flat grew by 120 bytes: (131212 to 131332)
pyro/RW/ec.RW.flat grew by 144 bytes: (130764 to 130908)

TEST=Build
BUG=None
BRANCH=None

Change-Id: I8d39db04c4ca3194f99e17840365429ed2d39390
Signed-off-by: Martin Roth <martinroth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/371401
Reviewed-by: Randall Spangler <rspangler@chromium.org>
2016-12-16 15:42:47 -08:00
..
acpi.c
common: Add tablet_mode API
2016-11-08 17:11:28 -08:00
adc.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
als.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
ap_hang_detect.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
backlight_lid.c
…
battery.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
bluetooth_le.c
btle: Cleanup: Moved constants, renamed functions
2016-08-11 14:46:33 -07:00
btle_hci_controller.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
btle_ll.c
btle_ll.c: Initialize variables to fix GCC warnings
2016-11-16 19:04:31 -08:00
build.mk
i2c_passthru: fix virtual battery operation
2016-12-14 06:03:14 -08:00
button.c
button: Add console command to simulate button press
2016-09-02 15:12:21 -07:00
capsense.c
Deferred: Use deferred_data instead of function pointer
2016-04-18 17:32:40 -07:00
case_closed_debug.c
g: use devid 0 and 1 to create a serial number
2016-10-11 23:01:59 -07:00
charge_manager.c
charge_manager: cleanup and document
2016-12-06 15:58:34 -08:00
charge_ramp.c
charge_ramp: Reduce max ICL if VBUS drops on stable ramp
2016-12-07 00:36:41 -08:00
charge_state_v1.c
cleanup: Rename charge_temp_sensor_get_val() to charge_get_battery_temp()
2016-10-14 18:49:36 -07:00
charge_state_v2.c
i2c_passthru: fix virtual battery operation
2016-12-14 06:03:14 -08:00
charger.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
chipset.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
clz.c
Add option to enable GCC LTO
2015-05-19 02:46:27 +00:00
console_output.c
Cr50: The chan command is not safe.
2016-10-01 03:13:43 +00:00
console.c
Cr50: Mark several console commands as safe
2016-08-31 17:20:26 +00:00
crc8.c
crc8: Support crc calculation across non-contiguous data
2016-03-18 22:16:53 -07:00
crc.c
Move software CRC implementation to common
2014-08-08 03:11:38 +00:00
device_state.c
Cr50: The devices command is safe.
2016-10-01 03:13:54 +00:00
dptf.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
ec.libsharedobjs.ld
build-infr: Add support for shared RO library.
2015-07-17 03:17:50 +00:00
extension.c
Cr50: Add TPM-compliant commands for console lock
2016-11-11 23:11:51 -08:00
extpower_gpio.c
extpower: Allow board to override signal debounce time
2016-09-02 07:11:33 -07:00
fan.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
firmware_image.lds.S
cr50: add ability to include two identical RW sections in the EC image
2015-12-09 06:36:22 -08:00
firmware_image.S
cr50: add ability to include two identical RW sections in the EC image
2015-12-09 06:36:22 -08:00
flash.c
flash: Call lock function prior to mapped external read
2016-09-16 21:59:08 -07:00
fmap.c
Fix various misspellings in comments
2016-11-15 17:41:53 -08:00
gesture.c
Fix various misspellings in comments
2016-11-15 17:41:53 -08:00
gpio_commands.c
Cr50: Mark several console commands as safe
2016-08-31 17:20:26 +00:00
gpio.c
servo_micro: add gpio mode get and set
2016-04-27 14:04:07 -07:00
hooks.c
common: Add TABLET_MODE hook.
2016-09-07 14:01:18 -07:00
host_command_master.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
host_command_pd.c
charge_state_v2: Limit i/p current to meet allowed MAX i/p system power
2016-12-05 16:43:00 -08:00
host_command.c
Revert "ec: Improve efficiency of host command dispatcher"
2016-11-26 01:29:24 +00:00
host_event_commands.c
mkbp: Always keep memmap host event mask up-to-date
2016-12-01 19:59:04 -08:00
i2c_wedge.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
i2c.c
common/i2c.c: Check that i2c port is always 0 or greater
2016-12-16 15:42:47 -08:00
i2cs_tpm.c
Cr50: I2CS TPM: Ensure HW read fifo is empty for register reads
2016-11-04 18:31:46 -07:00
inductive_charging.c
Deferred: Use deferred_data instead of function pointer
2016-04-18 17:32:40 -07:00
keyboard_8042_sharedlib.c
libsharedobjs: Add 8042 scancodes to shared lib.
2015-07-17 03:18:03 +00:00
keyboard_8042.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
keyboard_mkbp.c
common: Add tablet_mode API
2016-11-08 17:11:28 -08:00
keyboard_scan.c
keyboard: Always call keyboard_state_changed
2016-11-17 07:08:25 -08:00
keyboard_test.c
…
lb_common.c
ryu: fix max lightbar brightness
2015-09-25 09:13:34 -07:00
led_common.c
…
led_policy_std.c
led_policy_std: Blink LED in S0iX
2016-07-19 12:03:27 -07:00
lid_angle.c
oak: enable lid angle update
2016-03-02 13:39:47 -08:00
lid_switch.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
lightbar.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
mag_cal.c
common: Add magnetometer online calibration.
2015-10-13 05:28:54 -07:00
main.c
Fix various misspellings in comments
2016-11-15 17:41:53 -08:00
mat33.c
common: Add magnetometer online calibration.
2015-10-13 05:28:54 -07:00
mat44.c
common: Add magnetometer online calibration.
2015-10-13 05:28:54 -07:00
math_util.c
math_util: Fix rotation by identity.
2016-08-24 17:40:27 -07:00
memory_commands.c
Add more CONFIG_CMD_* options for console commands
2016-10-01 00:02:01 -07:00
mkbp_event.c
mkbp_event: Properly queue events during host sleep
2016-11-04 18:31:37 -07:00
motion_lid.c
motion_lid: Make tablet mode great (again).
2016-11-15 03:09:02 -08:00
motion_sense.c
common: Add tablet_mode API
2016-11-08 17:11:28 -08:00
nvmem.c
nvmem: fix partition number assignment in nvmem.c
2016-09-28 16:00:00 -07:00
onewire.c
…
panic_output.c
Cr50: The panicinfo command is not safe
2016-10-01 03:14:07 +00:00
pd_log.c
Fix various misspellings in comments
2016-11-15 17:41:53 -08:00
port80.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
power_button_x86.c
common: Add new recovery mode button combination
2016-11-08 20:30:07 -08:00
power_button.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
printf.c
printf: Add sign ('+') flag
2016-07-29 10:51:22 -07:00
pstore_commands.c
…
pwm_kblight.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
pwm.c
pwm: PWM is disabled when duty is set to max value
2016-09-08 17:57:51 -07:00
queue_policies.c
Stream: Remove in_stream/out_stream interface
2015-06-11 00:08:49 +00:00
queue.c
Queue: Add ability to modify contiguous units inplace
2015-07-15 21:57:36 +00:00
rsa.c
common/rsa: Add support for exponent 3 RSA keys
2016-11-10 21:28:28 -08:00
rwsig.c
cleanup: Handle signed RW images a bit cleaner
2015-09-25 19:36:37 -07:00
sha1.c
Add SHA-1 hash
2014-05-17 20:14:17 +00:00
sha256.c
common: Drop unused data structure
2016-05-05 19:16:50 -07:00
shared_mem.c
Cr50: Mark several console commands as safe
2016-08-31 17:20:26 +00:00
smbus.c
smbus: Re-write smbus driver
2016-03-21 16:35:33 -07:00
spi_commands.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
spi_flash_reg.c
spi_flash_reg: Correct lengths for W25Q40/GD25LQ40
2016-10-20 01:55:59 -07:00
spi_flash.c
Enable spi_flash_read to read > SPI_FLASH_MAX_READ_SIZE
2016-10-05 20:58:37 -07:00
spi_nor.c
spi_nor.c: Initialize variables to fix GCC warnings
2016-12-16 15:42:18 -08:00
switch.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
system.c
Add CONFIG_CMD_SYSINFO and CONFIG_CMD_SYSLOCK
2016-10-07 16:47:06 -07:00
tablet_mode.c
common: Add tablet_mode API
2016-11-08 17:11:28 -08:00
temp_sensor.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
test_util.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
thermal.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
throttle_ap.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
timer.c
task: Don't propagate TASK_EVENT_TIMER between between waits
2016-10-26 01:45:25 -07:00
tpm_registers.c
Cr50: Prevent rebooting when unlocking the console
2016-11-19 00:14:24 -08:00
uart_buffering.c
UART: Remove X-on/X-off flow control
2016-04-27 10:10:02 -07:00
update_fw.c
servo_v4: copypasta usb updater code into common
2016-07-21 13:13:35 -07:00
usb_charger.c
bd99955: Improve interrupt / USB charger task wake scheme
2016-06-16 12:27:42 -07:00
usb_i2c.c
usb_i2c: refactor into common
2016-11-02 17:39:56 -07:00
usb_pd_policy.c
usb_pd_policy: Automatically swap vconn if adapter requests it
2016-12-14 06:02:54 -08:00
usb_pd_protocol.c
usb_pd_protocol: Force rediscovering identity on boot
2016-12-14 06:02:56 -08:00
usb_pd_tcpc.c
tcpci_tcpm_get_message: TCPC_REG_RX_BYTE_CNT includes header
2016-12-08 22:47:00 -08:00
usb_port_power_dumb.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00
usb_port_power_smart.c
usb: power_smart: Allow CONFIG_USB_PORT_POWER_SMART_PORT_COUNT < 2
2016-09-22 19:12:36 -07:00
usb_update.c
servo_v4: copypasta usb updater code into common
2016-07-21 13:13:35 -07:00
util.c
Cr50: Use parse_bool() for boolean args
2016-08-22 23:27:24 -07:00
vboot_hash.c
flash: Call lock function prior to mapped external read
2016-09-16 21:59:08 -07:00
vec3.c
common: Add magnetometer online calibration.
2015-10-13 05:28:54 -07:00
version.c
Make builds repeatable.
2015-09-24 12:46:28 -07:00
virtual_battery.c
i2c_passthru: fix virtual battery operation
2016-12-14 06:03:14 -08:00
vstore.c
ec: Add temporary secure storage for the host during boot
2016-01-25 21:46:48 -08:00
wireless.c
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
2016-08-24 16:30:10 +00:00