mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2025-12-30 18:41:11 +00:00
114f5cee5a
The USB FW upgrade endpoint should really only accept vendor commands required to perform the firmware update. This commit adds a whitelist that is checked whenever a vendor command is received over this endpoint. The allowed commands over USB are the following: - EXTENSION_POST_RESET - VENDOR_CC_IMMEDIATE_RESET (only for dev images) There is also functionality to have a whitelist for vendor commands that come over the TPM interface. BUG=chrome-os-partner:62815 BRANCH=None TEST=Flash Cr50 with image containing this change. Verify that an upgrade over USB to newer image works. TEST=Try using usb_updater to send a vendor command that's not in the whitelist. Verify that the vendor command is dropped. Change-Id: I71f8ba090a1cc6c9e7c30ce0dd3c25259e8f292f Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/443447 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
76 lines
2.6 KiB
C
76 lines
2.6 KiB
C
/* Copyright 2015 The Chromium OS Authors. All rights reserved.
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#ifndef __EC_INCLUDE_EXTENSION_H
|
|
#define __EC_INCLUDE_EXTENSION_H
|
|
|
|
#include <stddef.h>
|
|
#include <stdint.h>
|
|
|
|
#include "common.h"
|
|
#include "tpm_vendor_cmds.h"
|
|
|
|
/*
|
|
* Type of function handling extension commands.
|
|
*
|
|
* @param buffer As input points to the input data to be processed, as
|
|
* output stores data, processing result.
|
|
* @param command_size Number of bytes of input data
|
|
* @param response_size On input - max size of the buffer, on output - actual
|
|
* number of data returned by the handler.
|
|
*/
|
|
typedef enum vendor_cmd_rc (*extension_handler)(enum vendor_cmd_cc code,
|
|
void *buffer,
|
|
size_t command_size,
|
|
size_t *response_size);
|
|
|
|
/**
|
|
* Find handler for an extension command.
|
|
*
|
|
* Use the interface specific function call in order to check the policies for
|
|
* handling the commands on that interface.
|
|
*
|
|
* @param command_code Code associated with a extension command handler.
|
|
* @param buffer Data to be processd by the handler, the same space
|
|
* is used for data returned by the handler.
|
|
* @command_size Size of the input data.
|
|
* @param size On input - max size of the buffer, on output - actual number of
|
|
* data returned by the handler. A single byte return
|
|
* usually indicates an error and contains the error code.
|
|
*/
|
|
uint32_t usb_extension_route_command(uint16_t command_code,
|
|
void *buffer,
|
|
size_t command_size,
|
|
size_t *size);
|
|
uint32_t tpm_extension_route_command(uint16_t command_code,
|
|
void *buffer,
|
|
size_t command_size,
|
|
size_t *size);
|
|
|
|
/* Pointer table */
|
|
struct extension_command {
|
|
uint16_t command_code;
|
|
extension_handler handler;
|
|
} __packed;
|
|
|
|
#define DECLARE_EXTENSION_COMMAND(code, func) \
|
|
static enum vendor_cmd_rc func##_wrap(enum vendor_cmd_cc code, \
|
|
void *cmd_body, \
|
|
size_t cmd_size, \
|
|
size_t *response_size) { \
|
|
func(cmd_body, cmd_size, response_size); \
|
|
return 0; \
|
|
} \
|
|
const struct extension_command __keep __extension_cmd_##code \
|
|
__attribute__((section(".rodata.extensioncmds"))) \
|
|
= {.command_code = code, .handler = func##_wrap }
|
|
|
|
#define DECLARE_VENDOR_COMMAND(code, func) \
|
|
const struct extension_command __keep __vendor_cmd_##code \
|
|
__attribute__((section(".rodata.extensioncmds"))) \
|
|
= {.command_code = code, .handler = func}
|
|
|
|
#endif /* __EC_INCLUDE_EXTENSION_H */
|