mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2026-01-07 16:11:43 +00:00
80778ad0eb
If 2 interrupts happen at the same time, there is a chance that the nested interrupt will not call svc_handler when it needs to. In extreme cases this could lead to tasks not getting woken up when they're supposed to and watchdog resetting. The reason stuff worked was because there were enough other interrupts around to eventually call the scheduler and switch to the ready task. This change modifies the interrupt calls to not call the scheduler directly (because in nested interrupt situation this causes problems), but defer the call to scheduling until after the irq finishes by triggering a low priority interrupt which will for sure call svc_host at the end. The PendSV irq was used for this purpose. BUG=chrome-os-partner:36193 TEST=No more SPI errors caused by scheduler problems TEST=usleeps now are more accurate, they're guaranteed to not take forever now BRANCH=veyron Change-Id: I42acde6b3eb7be2540a0de9a8562dee2ea2be7ab Signed-off-by: Alexandru M Stan <amstan@chromium.org> Signed-off-by: Vincent Palatin <vpalatin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/248902 Tested-by: Alec Berg <alecaberg@chromium.org> Reviewed-by: Alec Berg <alecaberg@chromium.org> Commit-Queue: Alec Berg <alecaberg@chromium.org>
43 lines
1.5 KiB
C
43 lines
1.5 KiB
C
/* Copyright (c) 2014 The Chromium OS Authors. All rights reserved.
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
/* Helper to declare IRQ handling routines */
|
|
|
|
#ifndef __IRQ_HANDLER_H
|
|
#define __IRQ_HANDLER_H
|
|
|
|
#include "cpu.h"
|
|
|
|
/* Helper macros to build the IRQ handler and priority struct names */
|
|
#define IRQ_HANDLER(irqname) CONCAT3(irq_, irqname, _handler)
|
|
#define IRQ_PRIORITY(irqname) CONCAT2(prio_, irqname)
|
|
|
|
/*
|
|
* Macro to connect the interrupt handler "routine" to the irq number "irq" and
|
|
* ensure it is enabled in the interrupt controller with the right priority.
|
|
*/
|
|
#define DECLARE_IRQ(irq, routine, priority) DECLARE_IRQ_(irq, routine, priority)
|
|
#ifdef CONFIG_TASK_PROFILING
|
|
#define DECLARE_IRQ_(irq, routine, priority) \
|
|
void IRQ_HANDLER(irq)(void) \
|
|
{ \
|
|
void *ret = __builtin_return_address(0); \
|
|
task_start_irq_handler(ret); \
|
|
routine(); \
|
|
task_end_irq_handler(ret); \
|
|
} \
|
|
const struct irq_priority IRQ_PRIORITY(irq) \
|
|
__attribute__((section(".rodata.irqprio"))) \
|
|
= {irq, priority}
|
|
#else /* CONFIG_TASK_PROFILING */
|
|
/* No Profiling : connect directly the IRQ vector */
|
|
#define DECLARE_IRQ_(irq, routine, priority) \
|
|
void IRQ_HANDLER(irq)(void) __attribute__((alias(STRINGIFY(routine))));\
|
|
const struct irq_priority IRQ_PRIORITY(irq) \
|
|
__attribute__((section(".rodata.irqprio"))) \
|
|
= {irq, priority}
|
|
#endif /* CONFIG_TASK_PROFILING */
|
|
#endif /* __IRQ_HANDLER_H */
|