mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2025-12-28 10:45:22 +00:00
bc11760a58
Currently, per-board defines use mixed case (BOARD_pit). This causes
the presubmit script to complain because that's a style violation.
Using --no-verify to bypass that also allows other style violations to
creep in.
This change adds uppercase variants (BOARD_PIT). It also adds a CORE_
define with '-' changed to '_', since CORE_cortex-m isn't a valid
symbol but CORE_CORTEX_M is (so now we can #ifdef CORE_CORTEX_M).
This does not remove the old mixed-case defines yet, nor does it
find/replace them in the C source files. This is intentional, so this
change can be cherry-picked into branches without needing to change
files in the branch that may have picked up new #ifdefs.
I will rename the constants in the C source files and remove the old
mixed-case defines in a follow-on CL, which should not need to get
picked into existing branches.
BUG=chromium:322144
BRANCH=none (but might need it if you later cherry-pick something with
an uppercase #ifdef BOARD_FOO
TEST=Build each board with V=1 option: 'make V=1 BOARD=foo all tests'.
Check that the compile command line has both mixed-case and
uppercase defines. Check that per-board tests from test/build.mk
were built (for example, BOARD_PIT should compile kb_scan and
stress, and BOARD_SAMUS should build none of them).
Change-Id: I5eb0d1fe57f1c694d7449e5f148e2f13fb290a39
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/179205
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
62 lines
2.5 KiB
Makefile
62 lines
2.5 KiB
Makefile
# -*- makefile -*-
|
|
# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
#
|
|
# Toolchain configuration build system
|
|
#
|
|
|
|
# Toolchain configuration
|
|
HOST_CROSS_COMPILE ?= x86_64-pc-linux-gnu-
|
|
|
|
CC=$(CROSS_COMPILE)gcc
|
|
CPP=$(CROSS_COMPILE)cpp
|
|
LD=$(CROSS_COMPILE)ld
|
|
OBJCOPY=$(CROSS_COMPILE)objcopy
|
|
OBJDUMP=$(CROSS_COMPILE)objdump
|
|
PKG_CONFIG?=pkg-config
|
|
BUILDCC?=gcc
|
|
HOSTCC?=$(HOST_CROSS_COMPILE)gcc
|
|
|
|
CFLAGS_WARN=-Wall -Werror -Wundef -Wstrict-prototypes -Wno-trigraphs \
|
|
-fno-strict-aliasing -fno-common \
|
|
-Werror-implicit-function-declaration -Wno-format-security \
|
|
-fno-delete-null-pointer-checks -Wdeclaration-after-statement \
|
|
-Wno-pointer-sign -fno-strict-overflow -fconserve-stack
|
|
CFLAGS_DEBUG= -g
|
|
CFLAGS_INCLUDE=$(foreach i,$(includes),-I$(i) ) -I.
|
|
CFLAGS_TEST=$(if $(TEST_BUILD),-DTEST_BUILD \
|
|
-DTEST_TASKFILE=$(PROJECT).tasklist,) \
|
|
$(if $(EMU_BUILD),-DEMU_BUILD) \
|
|
$(if $($(PROJECT)-scale),-DTEST_TIME_SCALE=$($(PROJECT)-scale)) \
|
|
-DTEST_$(PROJECT)
|
|
CFLAGS_COVERAGE=$(if $(TEST_COVERAGE),-fprofile-arcs -ftest-coverage \
|
|
-DTEST_COVERAGE,)
|
|
CFLAGS_DEFINE=-DOUTDIR=$(out) -DCHIP=$(CHIP) -DBOARD_TASKFILE=ec.tasklist \
|
|
-DBOARD=$(BOARD) -DBOARD_$(BOARD) -DCORE=$(CORE) \
|
|
-DPROJECT=$(PROJECT) -DCHIP_$(CHIP) \
|
|
-DCHIP_VARIANT=$(CHIP_VARIANT) -DCHIP_VARIANT_$(CHIP_VARIANT) \
|
|
-DCHIP_FAMILY=$(CHIP_FAMILY) -DCHIP_FAMILY_$(CHIP_FAMILY) \
|
|
-DBOARD_$(UC_BOARD) -DCHIP_$(UC_CHIP) -DCORE_$(UC_CORE) \
|
|
-DCHIP_VARIANT_$(UC_CHIP_VARIANT) -DCHIP_FAMILY_$(UC_CHIP_FAMILY)
|
|
CPPFLAGS=$(CFLAGS_DEFINE) $(CFLAGS_INCLUDE) $(CFLAGS_TEST) \
|
|
$(EXTRA_CFLAGS) $(CFLAGS_COVERAGE)
|
|
CFLAGS=$(CPPFLAGS) $(CFLAGS_CPU) $(CFLAGS_DEBUG) $(CFLAGS_WARN) $(CFLAGS_y)
|
|
|
|
FTDIVERSION=$(shell $(PKG_CONFIG) --modversion libftdi1 2>/dev/null)
|
|
ifneq ($(FTDIVERSION),)
|
|
LIBFTDI_NAME=ftdi1
|
|
else
|
|
LIBFTDI_NAME=ftdi
|
|
endif
|
|
|
|
LIBFTDI_CFLAGS=$(shell $(PKG_CONFIG) --cflags lib${LIBFTDI_NAME})
|
|
LIBFTDI_LDLIBS=$(shell $(PKG_CONFIG) --libs lib${LIBFTDI_NAME})
|
|
|
|
BUILD_CFLAGS= $(LIBFTDI_CFLAGS) $(CPPFLAGS) -O3 $(CFLAGS_DEBUG) $(CFLAGS_WARN)
|
|
HOST_CFLAGS=$(CPPFLAGS) -O3 $(CFLAGS_DEBUG) $(CFLAGS_WARN)
|
|
LDFLAGS=-nostdlib -X
|
|
BUILD_LDFLAGS=$(LIBFTDI_LDLIBS)
|
|
HOST_TEST_LDFLAGS=-T core/host/host_exe.lds -lrt -pthread \
|
|
$(if $(TEST_COVERAGE),-fprofile-arcs,)
|