David Hendricks 29af184eb7 copy reboot parameters in host_command_reboot() ...

Currently host_command_reboot() casts the supplied buffer and access
it directly. This works until about half-way thru the function when
the same buffer potentially gets overwritten when sending the response
code to the host.

This CL gets around that by copying the reboot parameters into a
separate buffer.

Signed-off-by: David Hendricks <dhendrix@chromium.org>
BUG=none
TEST=Tested using 'ectool reboot_ec' on Snow (see below)

Before, EC console displayed "[Executing host reboot command]" and
ectool showed no actual change (reboot command was being overwritten
with EC_REBOOT_CANCEL):
localhost ~ # ectool version | grep 'Firmware copy'
Firmware copy: RO
localhost ~ # ectool reboot_ec A
localhost ~ # ectool version | grep 'Firmware copy'
Firmware copy: RO

With the patch applied, the EC console shows the EC boot-up messages
and ectool confirms that the jump took place:
localhost ~ # ectool version | grep 'Firmware copy'
Firmware copy: RO
localhost ~ # ectool reboot_ec A
localhost ~ # ectool version | grep 'Firmware copy'
Firmware copy: A

Change-Id: I8aca8d468d1125c3fb8d320ec0fb79d2822b0b20
Reviewed-on: https://gerrit.chromium.org/gerrit/26998
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Tested-by: David Hendricks <dhendrix@chromium.org>
Commit-Ready: David Hendricks <dhendrix@chromium.org>

2012-07-10 11:27:08 -07:00

..

battery_atl706486.c

Fix a bug in battery temperature cut off

2012-06-28 23:44:41 -07:00

battery_precharge.c

Trickle charging state and minor bugs fix

2012-04-19 01:16:01 +08:00

build.mk

Support host event get/set/clear on all host interfaces

2012-07-07 17:36:46 -07:00

charge_state.c

Support host event get/set/clear on all host interfaces

2012-07-07 17:36:46 -07:00

charger_bq24725.c

Better help for console commands

2012-05-25 13:34:06 -07:00

console_output.c

Split console output into its own module

2012-06-13 13:17:33 -07:00

console.c

Split console output into its own module

2012-06-13 13:17:33 -07:00

eoption.c

Better help for console commands

2012-05-25 13:34:06 -07:00

firmware_image.lds.S

Only one RW image is now the default

2012-06-26 13:58:54 -07:00

firmware_image.S

Only one RW image is now the default

2012-06-26 13:58:54 -07:00

flash_commands.c

Remove flash checksum host command

2012-06-29 15:01:40 -07:00

flash_common.c

CHERRY-PICK: stm32: de-activate all flash accesses for pstate

2012-07-03 23:51:19 -07:00

fmap.c

Use __packed instead of __attribute__((packed))

2012-06-28 17:40:39 -07:00

gaia_power.c

gaia: add lid switch functionality to power states

2012-07-07 19:34:53 -07:00

gpio_commands.c

Better help for console commands

2012-05-25 13:34:06 -07:00

hooks.c

Disable touchscreen when lid is closed and in S3

2012-05-21 16:30:12 -07:00

host_command.c

Add new event for host interface ready

2012-07-07 23:05:50 -07:00

host_event_commands.c

Support host event get/set/clear on all host interfaces

2012-07-07 17:36:46 -07:00

i8042.c

Refactor the i8042 module to be thread-safe.

2012-06-07 20:48:51 -07:00

ir357x.c

link: update VR settings

2012-06-22 15:35:41 -07:00

keyboard.c

Lock out MKBP_SIMULATE_KEY host command when WP is enabled

2012-07-09 14:42:09 -07:00

lightbar.c

Remove proto1 workarounds

2012-06-25 15:37:41 -07:00

main.c

Only disable sysjump in main if we're doing signature-based verified boot

2012-07-09 10:58:14 -07:00

memory_commands.c

Better help for console commands

2012-05-25 13:34:06 -07:00

mock_charger.c

Add a test of charging state machine

2012-07-08 20:25:17 -07:00

mock_i8042.c

Add a test of i8042 scancode set

2012-06-27 00:55:04 -07:00

mock_smart_battery_stub.c

Add a test of charging state machine

2012-07-08 20:25:17 -07:00

mock_temp_sensor.c

Thermal engine unit test

2012-06-25 07:15:50 -07:00

mock_x86_power.c

Add a test of charging state machine

2012-07-08 20:25:17 -07:00

pmu_tps65090_charger.c

Initialize PMU default settings using board configuration

2012-07-03 23:51:19 -07:00

pmu_tps65090.c

snow: Add pmu command to print out pmu registers

2012-07-05 22:56:39 -07:00

port80.c

If port 80 buffer isn't full, only print partial contents

2012-06-18 11:48:15 -07:00

power_led.c

Better help for console commands

2012-05-25 13:34:06 -07:00

printf.c

Fix printing hex numbers

2012-06-07 14:33:26 -07:00

pstore_commands.c

de-LPCify the EC host interface

2012-05-15 18:34:50 -07:00

pwm_commands.c

Add 'fanduty' command both EC console and ectool.

2012-06-22 15:56:57 -07:00

queue.c

Refactor the i8042 module to be thread-safe.

2012-06-07 20:48:51 -07:00

shared_mem.c

Implement HOOK_SYSJUMP and use it to preserve LPC host event mask

2012-04-19 18:15:18 -07:00

smart_battery_stub.c

Stub smart battery read/write functions

2012-06-27 03:22:17 -07:00

smart_battery.c

Add a repeat count parameter to the battery command

2012-07-02 22:35:51 -07:00

system_common.c

copy reboot parameters in host_command_reboot()

2012-07-10 11:27:08 -07:00

temp_sensor_commands.c

Remove hardcoded size in temp_sensor_command_get_info()

2012-07-03 10:50:46 -07:00

temp_sensor.c

Add memory-mapped data support for I2C and SPI protocols

2012-07-07 17:14:18 -07:00

thermal_commands.c

Fix a bug that 'ectool thermalget' silently fails

2012-05-21 16:46:59 +08:00

thermal.c

Support host event get/set/clear on all host interfaces

2012-07-07 17:36:46 -07:00

tmp006.c

Add a way to set indiviual sensitivity factor for each TMP006 sensor

2012-05-28 16:42:17 +08:00

uart_buffering.c

Increase UART output buffer size on LM4

2012-07-07 23:05:50 -07:00

usb_charge_commands.c

de-LPCify the EC host interface

2012-05-15 18:34:50 -07:00

usb_charge.c

Better help for console commands

2012-05-25 13:34:06 -07:00

util.c

Prevent strzcpy access out-of-bound

2012-07-03 10:50:45 -07:00

vboot_hash.c

Add hash support

2012-06-25 15:37:42 -07:00

vboot_sig.c

Refactor boot key detection

2012-06-26 17:01:52 -07:00

vboot_stub.c

Enable verified boot for EC firmware

2012-05-10 17:27:36 -07:00

vboot.c

Only one RW image is now the default

2012-06-26 13:58:54 -07:00

version.c

update versioning information stored in the EC

2012-03-02 16:46:26 +00:00

x86_power.c

x86power module must init before power button module

2012-07-03 23:51:16 -07:00