mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2025-12-29 18:11:05 +00:00
9968fb3966
The code in core/cortex-m/init.S limits the number of installed
vectors to CONFIG_IRQ_COUNT. But the DECLARE_IRQ macro installing
interrupt servicing routines does not care about this limitation. This
results in corrupted interrupt configuration, which is hard to debug.
This patch makes sure that there is a compilation error in case
DECLARE_IRQ is passed interrupt number which out of bounds.
A similar change needs to be introduced for cortex-m0.
BRANCH=none
BUG=chromium:518898
TEST=tried building cr50 with one of interrupt numbers exceeding
CONFIG_IRQ_COUNT, observed a compilation error.
Change-Id: Ie7bc623da6bf7371579b2242064f81a83053df17
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/291843
Reviewed-by: Randall Spangler <rspangler@chromium.org>
45 lines
1.5 KiB
C
45 lines
1.5 KiB
C
/* Copyright (c) 2014 The Chromium OS Authors. All rights reserved.
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
/* Helper to declare IRQ handling routines */
|
|
|
|
#ifndef __CROS_EC_IRQ_HANDLER_H
|
|
#define __CROS_EC_IRQ_HANDLER_H
|
|
|
|
#ifdef CONFIG_TASK_PROFILING
|
|
#define bl_task_start_irq_handler "bl task_start_irq_handler\n"
|
|
#else
|
|
#define bl_task_start_irq_handler ""
|
|
#endif
|
|
|
|
/* Helper macros to build the IRQ handler and priority struct names */
|
|
#define IRQ_HANDLER(irqname) CONCAT3(irq_, irqname, _handler)
|
|
#define IRQ_PRIORITY(irqname) CONCAT2(prio_, irqname)
|
|
/*
|
|
* Macro to connect the interrupt handler "routine" to the irq number "irq" and
|
|
* ensure it is enabled in the interrupt controller with the right priority.
|
|
*/
|
|
#define DECLARE_IRQ(irq, routine, priority) DECLARE_IRQ_(irq, routine, priority)
|
|
#define DECLARE_IRQ_(irq, routine, priority) \
|
|
void IRQ_HANDLER(irq)(void) __attribute__((naked)); \
|
|
typedef struct { \
|
|
int dummy[irq >= CONFIG_IRQ_COUNT ? -1 : 1]; \
|
|
} irq_num_check_##irq; \
|
|
void __keep routine(void); \
|
|
void IRQ_HANDLER(irq)(void) \
|
|
{ \
|
|
asm volatile("mov r0, lr\n" \
|
|
"push {r0, lr}\n" \
|
|
bl_task_start_irq_handler \
|
|
"bl "#routine"\n" \
|
|
"pop {r0, lr}\n" \
|
|
"b task_resched_if_needed\n" \
|
|
); \
|
|
} \
|
|
const struct irq_priority IRQ_PRIORITY(irq) \
|
|
__attribute__((section(".rodata.irqprio"))) \
|
|
= {irq, priority}
|
|
#endif /* __CROS_EC_IRQ_HANDLER_H */
|