Files
OpenCellular/chip/host/gpio.c
Randall Spangler 7f3ed512db gpio: Make GPIO_INT_BOTH explicitly RISING|FALLING
For historical reasons on LM4, we defined GPIO_INT_F_BOTH separately
from GPIO_INT_F_RISING and GPIO_INT_F_FALLING.  This means that the
code has weird checks like BOTH || (RISING && FALLING), which have
propagated in error-prone ways across the other chips.

Instead, explcitly define BOTH to be RISING|FALLING.

Ideally, we would have called it GPIO_INT_EDGE to match
GPIO_INT_LEVEL, but changing that now would be a big find-replace.
Which might still be a good idea, but that is best done in its own CL.

BUG=chrome-os-partner:24204
BRANCH=none
TEST=build and boot pit, spring, and link; that covers STM32F, STM32L, and LM4.

Change-Id: I23ba05a3f41bb14b09af61dc52a178f710f5c1bb
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/177643
Reviewed-by: Jeremy Thorpe <jeremyt@chromium.org>
Reviewed-by: Vic Yang <victoryang@chromium.org>
2013-11-23 05:11:31 +00:00

73 lines
1.6 KiB
C

/* Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
/* GPIO module for emulator */
#include "console.h"
#include "common.h"
#include "gpio.h"
#include "timer.h"
#include "util.h"
static int gpio_values[GPIO_COUNT];
static int gpio_interrupt_enabled[GPIO_COUNT];
test_mockable void gpio_pre_init(void)
{
/* Nothing */
}
test_mockable int gpio_get_level(enum gpio_signal signal)
{
return gpio_values[signal];
}
static int gpio_interrupt_check(uint32_t flags, int old, int new)
{
if ((flags & GPIO_INT_F_RISING) && old == 0 && new == 1)
return 1;
if ((flags & GPIO_INT_F_FALLING) && old == 1 && new == 0)
return 1;
if ((flags & GPIO_INT_F_LOW) && new == 0)
return 1;
if ((flags & GPIO_INT_F_HIGH) && new == 1)
return 1;
return 0;
}
test_mockable void gpio_set_level(enum gpio_signal signal, int value)
{
const struct gpio_info *g = gpio_list + signal;
const uint32_t flags = g->flags;
const int old_value = gpio_values[signal];
gpio_values[signal] = value;
if (g->irq_handler == NULL || !gpio_interrupt_enabled[signal])
return;
if (gpio_interrupt_check(flags, old_value, value))
g->irq_handler(signal);
}
test_mockable int gpio_enable_interrupt(enum gpio_signal signal)
{
gpio_interrupt_enabled[signal] = 1;
return EC_SUCCESS;
}
test_mockable void gpio_set_flags_by_mask(uint32_t port, uint32_t mask,
uint32_t flags)
{
/* Nothing */
}
test_mockable void gpio_set_alternate_function(uint32_t port, uint32_t mask,
int func)
{
/* Nothing */
}