mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2025-11-24 02:05:01 +00:00
Bit 2 in the GPT partition attributes has been allocated as the legacy bios boot (equivalent to the "active" or "boot" flag in MBR). If we try to boot images on newer x86 systems, syslinux dies because it can't find any GPT partition marked bootable. Update the various parts of cgpt add & show to manage this bit. Now we can run: cgpt add -i 12 -B 1 chromiumos_image.bin And the EFI partition will be marked bootable. BUG=chromium:644845 TEST=vboot_reference unittests pass TEST=booted an amd64-generic disk image via USB on a generic laptop BRANCH=None Change-Id: I78e17b8df5b0c61e9e2d8a3c703e6d5ad230fe92 Reviewed-on: https://chromium-review.googlesource.com/382411 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org>
151 lines
4.2 KiB
C
151 lines
4.2 KiB
C
// Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <getopt.h>
|
|
#include <string.h>
|
|
|
|
#include "cgpt.h"
|
|
#include "vboot_host.h"
|
|
|
|
extern const char* progname;
|
|
|
|
static void Usage(void)
|
|
{
|
|
printf("\nUsage: %s add [OPTIONS] DRIVE\n\n"
|
|
"Add, edit, or remove a partition entry.\n\n"
|
|
"Options:\n"
|
|
" -D NUM Size (in bytes) of the disk where partitions reside\n"
|
|
" default 0, meaning partitions and GPT structs are\n"
|
|
" both on DRIVE\n"
|
|
" -i NUM Specify partition (default is next available)\n"
|
|
" -b NUM Beginning sector\n"
|
|
" -s NUM Size in sectors\n"
|
|
" -t GUID Partition Type GUID\n"
|
|
" -u GUID Partition Unique ID\n"
|
|
" -l LABEL Label\n"
|
|
" -S NUM set Successful flag (0|1)\n"
|
|
" -T NUM set Tries flag (0-15)\n"
|
|
" -P NUM set Priority flag (0-15)\n"
|
|
" -B NUM set Legacy Boot flag (0|1)\n"
|
|
" -A NUM set raw 16-bit attribute value (bits 48-63)\n"
|
|
"\n"
|
|
"Use the -i option to modify an existing partition.\n"
|
|
"The -b, -s, and -t options must be given for new partitions.\n"
|
|
"\n", progname);
|
|
PrintTypes();
|
|
}
|
|
|
|
int cmd_add(int argc, char *argv[]) {
|
|
|
|
CgptAddParams params;
|
|
memset(¶ms, 0, sizeof(params));
|
|
|
|
int c;
|
|
int errorcnt = 0;
|
|
char *e = 0;
|
|
|
|
opterr = 0; // quiet, you
|
|
while ((c=getopt(argc, argv, ":hi:b:s:t:u:l:S:T:P:B:A:D:")) != -1)
|
|
{
|
|
switch (c)
|
|
{
|
|
case 'D':
|
|
params.drive_size = strtoull(optarg, &e, 0);
|
|
errorcnt += check_int_parse(c, e);
|
|
break;
|
|
case 'i':
|
|
params.partition = (uint32_t)strtoul(optarg, &e, 0);
|
|
errorcnt += check_int_parse(c, e);
|
|
break;
|
|
case 'b':
|
|
params.set_begin = 1;
|
|
params.begin = strtoull(optarg, &e, 0);
|
|
errorcnt += check_int_parse(c, e);
|
|
break;
|
|
case 's':
|
|
params.set_size = 1;
|
|
params.size = strtoull(optarg, &e, 0);
|
|
errorcnt += check_int_parse(c, e);
|
|
break;
|
|
case 't':
|
|
params.set_type = 1;
|
|
if (CGPT_OK != SupportedType(optarg, ¶ms.type_guid) &&
|
|
CGPT_OK != StrToGuid(optarg, ¶ms.type_guid)) {
|
|
Error("invalid argument to -%c: %s\n", c, optarg);
|
|
errorcnt++;
|
|
}
|
|
break;
|
|
case 'u':
|
|
params.set_unique = 1;
|
|
if (CGPT_OK != StrToGuid(optarg, ¶ms.unique_guid)) {
|
|
Error("invalid argument to -%c: %s\n", c, optarg);
|
|
errorcnt++;
|
|
}
|
|
break;
|
|
case 'l':
|
|
params.label = optarg;
|
|
break;
|
|
case 'S':
|
|
params.set_successful = 1;
|
|
params.successful = (uint32_t)strtoul(optarg, &e, 0);
|
|
errorcnt += check_int_parse(c, e);
|
|
errorcnt += check_int_limit(c, params.successful, 0, 1);
|
|
break;
|
|
case 'T':
|
|
params.set_tries = 1;
|
|
params.tries = (uint32_t)strtoul(optarg, &e, 0);
|
|
errorcnt += check_int_parse(c, e);
|
|
errorcnt += check_int_limit(c, params.tries, 0, 15);
|
|
break;
|
|
case 'P':
|
|
params.set_priority = 1;
|
|
params.priority = (uint32_t)strtoul(optarg, &e, 0);
|
|
errorcnt += check_int_parse(c, e);
|
|
errorcnt += check_int_limit(c, params.priority, 0, 15);
|
|
break;
|
|
case 'B':
|
|
params.set_legacy_boot = 1;
|
|
params.legacy_boot = (uint32_t)strtoul(optarg, &e, 0);
|
|
errorcnt += check_int_parse(c, e);
|
|
errorcnt += check_int_limit(c, params.legacy_boot, 0, 1);
|
|
break;
|
|
case 'A':
|
|
params.set_raw = 1;
|
|
params.raw_value = strtoull(optarg, &e, 0);
|
|
errorcnt += check_int_parse(c, e);
|
|
break;
|
|
|
|
case 'h':
|
|
Usage();
|
|
return CGPT_OK;
|
|
case '?':
|
|
Error("unrecognized option: -%c\n", optopt);
|
|
errorcnt++;
|
|
break;
|
|
case ':':
|
|
Error("missing argument to -%c\n", optopt);
|
|
errorcnt++;
|
|
break;
|
|
default:
|
|
errorcnt++;
|
|
break;
|
|
}
|
|
}
|
|
if (errorcnt)
|
|
{
|
|
Usage();
|
|
return CGPT_FAILED;
|
|
}
|
|
|
|
if (optind >= argc)
|
|
{
|
|
Error("missing drive argument\n");
|
|
return CGPT_FAILED;
|
|
}
|
|
|
|
params.drive_name = argv[optind];
|
|
|
|
return CgptAdd(¶ms);
|
|
}
|