mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2025-12-31 02:51:26 +00:00
fcce7223a5
Problems with existing thermal control loop:
* Not multi-board friendly. thermal.c only supports Link and needs
refactoring. Temp thresholds and fan speeds are hard-coded.
* Only the PECI temp is used to determine the fan speed. Other temp sensors
are ignored.
* Has confusing data structures. Values in the CPU temp thresholds array mix
ACPI thresholds with fan step values.
With this change, the thermal task monitors all temp sensors in order to
perform two completely independent functions:
Function one: Determine if the host needs to be throttled by or informed of
any thermal events.
For thermal events, each temp sensor will have three threshold levels.
TEMP_HOST_WARN
* When any sensor goes above this level, host_throttle_cpu(1) will be called
to ask the CPU to slow itself down.
* When all sensors drop below this level, host_throttle_cpu(0) will be called.
* Exactly AT this level, nothing happens (this provides hysteresis).
TEMP_HOST_HIGH
* When any sensor goes above this level, chipset_throttle_cpu(1) will be
called to slow the CPU down whether it wants to or not.
* When all sensors drop below this level, chipset_throttle_cpu(0) will be
called.
* Exactly AT this level, nothing happens (this provides hysteresis).
TEMP_HOST_SHUTDOWN
* When any sensor is above this level, chipset_force_shutdown() will be
called to halt the CPU.
* Nothing turns the CPU back on again - the user just has to wait for things
to cool off. Pressing the power button too soon will just trigger shutdown
again as soon as the EC can read the host temp.
Function two: Determine the amount of fan cooling needed
For fan cooling, each temp sensor will have two levels.
TEMP_FAN_OFF
* At or below this temperature, no active cooling is needed.
TEMP_FAN_MAX
* At or above this temperature, active cooling should be running at maximum.
The highest level of all temp sensors will be used to request the amount of
active cooling needed. The function pwm_fan_percent_to_rpm() is invoked to
convert the amount of cooling to the target fan RPM.
The default pwm_fan_percent_to_rpm() function converts smoothly between the
configured CONFIG_PWM_FAN_RPM_MIN and CONFIG_PWM_FAN_RPM_MAX for percentages
between 1 and 100. 0% means "off".
The default function probably provide the smoothest and quietest behavior,
but individual boards can provide their own pwm_fan_percent_to_rpm() to
implement whatever curves, hysteresis, feedback, or other hackery they wish.
BUG=chrome-os-partner:20805
BRANCH=none
TEST=manual
Compile-time test with
make BOARD=falco runtests
On the EC console, the existing fan commands should work correctly:
faninfo - display the fan state
fanduty NUM - force the fan PWM to the specified percentage (0-100)
fanset RPM - force the fan to the specified RPM
fanset NUM% - force the fan to the specified percentage (0-100) between
its configured minimum and maximum speeds from board.h
(CONFIG_PWM_FAN_RPM_MIN and CONFIG_PWM_FAN_RPM_MAX)
fanauto - let the EC control the fan automatically
You can test the default pwm_fan_percent_to_rpm() with
fanset 1%
faninfo
The fan should be turning at CONFIG_PWM_FAN_RPM_MIN. Let the EC control it
automatically again with
fanauto
Also on the EC console, the thermal settings can be examined or changed:
> temps
PECI : 327 K = 54 C
ECInternal : 320 K = 47 C
G781Internal : 319 K = 46 C
G781External : 318 K = 45 C
>
> thermalget
sensor warn high shutdown fan_off fan_max name
0 373 387 383 333 363 PECI
1 0 0 0 0 0 ECInternal
2 0 0 0 0 0 G781Internal
3 0 0 0 0 0 G781External
>
> help thermalset
Usage: thermalset sensor warn [high [shutdown [fan_off [fan_max]]]]
set thermal parameters (-1 to skip)
>
> thermalset 2 -1 -1 999
sensor warn high shutdown fan_off fan_max name
0 373 387 383 333 363 PECI
1 0 0 0 0 0 ECInternal
2 0 0 999 0 0 G781Internal
3 0 0 0 0 0 G781External
>
From the host, ectool can be used to get and set these parameters with
nearly identical commands:
ectool thermalget
ectool thermalset 2 -1 -1 999
Change-Id: Idb27977278f766826045fb7d41929953ec6b1cca
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/66688
Reviewed-by: Randall Spangler <rspangler@chromium.org>
497 lines
9.8 KiB
C
497 lines
9.8 KiB
C
/* Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*
|
|
* Test thermal engine.
|
|
*/
|
|
|
|
#include "common.h"
|
|
#include "console.h"
|
|
#include "fan.h"
|
|
#include "hooks.h"
|
|
#include "host_command.h"
|
|
#include "printf.h"
|
|
#include "temp_sensor.h"
|
|
#include "test_util.h"
|
|
#include "thermal.h"
|
|
#include "timer.h"
|
|
#include "util.h"
|
|
|
|
|
|
/*****************************************************************************/
|
|
/* Exported data */
|
|
|
|
struct ec_thermal_config thermal_params[TEMP_SENSOR_COUNT];
|
|
|
|
/* The tests below make some assumptions. */
|
|
BUILD_ASSERT(TEMP_SENSOR_COUNT == 4);
|
|
BUILD_ASSERT(EC_TEMP_THRESH_COUNT == 3);
|
|
|
|
/*****************************************************************************/
|
|
/* Mock functions */
|
|
|
|
static int mock_temp[TEMP_SENSOR_COUNT];
|
|
static int host_throttled;
|
|
static int cpu_throttled;
|
|
static int cpu_shutdown;
|
|
static int fan_pct;
|
|
static int no_temps_read;
|
|
|
|
int temp_sensor_read(enum temp_sensor_id id, int *temp_ptr)
|
|
{
|
|
if (mock_temp[id] >= 0) {
|
|
*temp_ptr = mock_temp[id];
|
|
return EC_SUCCESS;
|
|
}
|
|
|
|
return EC_ERROR_NOT_POWERED;
|
|
}
|
|
|
|
void chipset_force_shutdown(void)
|
|
{
|
|
cpu_shutdown = 1;
|
|
}
|
|
|
|
void chipset_throttle_cpu(int throttled)
|
|
{
|
|
cpu_throttled = throttled;
|
|
}
|
|
|
|
void host_throttle_cpu(int throttled)
|
|
{
|
|
host_throttled = throttled;
|
|
}
|
|
|
|
void pwm_fan_set_percent_needed(int pct)
|
|
{
|
|
fan_pct = pct;
|
|
}
|
|
|
|
void smi_sensor_failure_warning(void)
|
|
{
|
|
no_temps_read = 1;
|
|
}
|
|
|
|
/*****************************************************************************/
|
|
/* Test utilities */
|
|
|
|
static void set_temps(int t0, int t1, int t2, int t3)
|
|
{
|
|
mock_temp[0] = t0;
|
|
mock_temp[1] = t1;
|
|
mock_temp[2] = t2;
|
|
mock_temp[3] = t3;
|
|
}
|
|
|
|
static void all_temps(int t)
|
|
{
|
|
set_temps(t, t, t, t);
|
|
}
|
|
|
|
static void reset_mocks(void)
|
|
{
|
|
/* Ignore all sensors */
|
|
memset(thermal_params, 0, sizeof(thermal_params));
|
|
|
|
/* All sensors report error anyway */
|
|
set_temps(-1, -1 , -1, -1);
|
|
|
|
/* Reset expectations */
|
|
host_throttled = 0;
|
|
cpu_throttled = 0;
|
|
cpu_shutdown = 0;
|
|
fan_pct = 0;
|
|
no_temps_read = 0;
|
|
}
|
|
|
|
|
|
/*****************************************************************************/
|
|
/* Tests */
|
|
|
|
static int test_init_val(void)
|
|
{
|
|
reset_mocks();
|
|
sleep(2);
|
|
|
|
TEST_ASSERT(host_throttled == 0);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
TEST_ASSERT(fan_pct == 0);
|
|
TEST_ASSERT(no_temps_read);
|
|
|
|
sleep(2);
|
|
|
|
TEST_ASSERT(host_throttled == 0);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
TEST_ASSERT(fan_pct == 0);
|
|
TEST_ASSERT(no_temps_read);
|
|
|
|
return EC_SUCCESS;
|
|
}
|
|
|
|
static int test_sensors_can_be_read(void)
|
|
{
|
|
reset_mocks();
|
|
mock_temp[2] = 100;
|
|
|
|
sleep(2);
|
|
|
|
TEST_ASSERT(host_throttled == 0);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
TEST_ASSERT(fan_pct == 0);
|
|
TEST_ASSERT(no_temps_read == 0);
|
|
|
|
return EC_SUCCESS;
|
|
}
|
|
|
|
|
|
static int test_one_fan(void)
|
|
{
|
|
reset_mocks();
|
|
thermal_params[2].temp_fan_off = 100;
|
|
thermal_params[2].temp_fan_max = 200;
|
|
|
|
all_temps(50);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 0);
|
|
|
|
all_temps(100);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 0);
|
|
|
|
all_temps(101);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 1);
|
|
|
|
all_temps(130);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 30);
|
|
|
|
all_temps(150);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 50);
|
|
|
|
all_temps(170);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 70);
|
|
|
|
all_temps(200);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 100);
|
|
|
|
all_temps(300);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 100);
|
|
|
|
return EC_SUCCESS;
|
|
}
|
|
|
|
static int test_two_fans(void)
|
|
{
|
|
reset_mocks();
|
|
|
|
thermal_params[1].temp_fan_off = 120;
|
|
thermal_params[1].temp_fan_max = 160;
|
|
thermal_params[2].temp_fan_off = 100;
|
|
thermal_params[2].temp_fan_max = 200;
|
|
|
|
all_temps(50);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 0);
|
|
|
|
all_temps(100);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 0);
|
|
|
|
all_temps(101);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 1);
|
|
|
|
all_temps(130);
|
|
sleep(2);
|
|
/* fan 2 is still higher */
|
|
TEST_ASSERT(fan_pct == 30);
|
|
|
|
all_temps(150);
|
|
sleep(2);
|
|
/* now fan 1 is higher: 150 = 75% of [120-160] */
|
|
TEST_ASSERT(fan_pct == 75);
|
|
|
|
all_temps(170);
|
|
sleep(2);
|
|
/* fan 1 is maxed now */
|
|
TEST_ASSERT(fan_pct == 100);
|
|
|
|
all_temps(200);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 100);
|
|
|
|
all_temps(300);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 100);
|
|
|
|
return EC_SUCCESS;
|
|
}
|
|
|
|
static int test_all_fans(void)
|
|
{
|
|
reset_mocks();
|
|
|
|
thermal_params[0].temp_fan_off = 20;
|
|
thermal_params[0].temp_fan_max = 60;
|
|
thermal_params[1].temp_fan_off = 120;
|
|
thermal_params[1].temp_fan_max = 160;
|
|
thermal_params[2].temp_fan_off = 100;
|
|
thermal_params[2].temp_fan_max = 200;
|
|
thermal_params[3].temp_fan_off = 300;
|
|
thermal_params[3].temp_fan_max = 500;
|
|
|
|
set_temps(1, 1, 1, 1);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 0);
|
|
|
|
/* Each sensor has its own range */
|
|
set_temps(40, 0, 0, 0);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 50);
|
|
|
|
set_temps(0, 140, 0, 0);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 50);
|
|
|
|
set_temps(0, 0, 150, 0);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 50);
|
|
|
|
set_temps(0, 0, 0, 400);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 50);
|
|
|
|
set_temps(60, 0, 0, 0);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 100);
|
|
|
|
set_temps(0, 160, 0, 0);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 100);
|
|
|
|
set_temps(0, 0, 200, 0);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 100);
|
|
|
|
set_temps(0, 0, 0, 500);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 100);
|
|
|
|
/* But sensor 0 needs the most cooling */
|
|
all_temps(20);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 0);
|
|
|
|
all_temps(21);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 2);
|
|
|
|
all_temps(30);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 25);
|
|
|
|
all_temps(40);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 50);
|
|
|
|
all_temps(50);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 75);
|
|
|
|
all_temps(60);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 100);
|
|
|
|
all_temps(65);
|
|
sleep(2);
|
|
TEST_ASSERT(fan_pct == 100);
|
|
|
|
return EC_SUCCESS;
|
|
}
|
|
|
|
static int test_one_limit(void)
|
|
{
|
|
reset_mocks();
|
|
thermal_params[2].temp_host[EC_TEMP_THRESH_WARN] = 100;
|
|
thermal_params[2].temp_host[EC_TEMP_THRESH_HIGH] = 200;
|
|
thermal_params[2].temp_host[EC_TEMP_THRESH_HALT] = 300;
|
|
|
|
all_temps(50);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 0);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(100);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 0);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(101);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(100);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(99);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 0);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(199);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(200);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(201);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 1);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(200);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 1);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(199);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(99);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 0);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(201);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 1);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(99);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 0);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
all_temps(301);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 1);
|
|
TEST_ASSERT(cpu_shutdown == 1);
|
|
|
|
/* We probably won't be able to read the CPU temp while shutdown,
|
|
* so nothing will change. */
|
|
all_temps(-1);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 1);
|
|
/* cpu_shutdown is only set for testing purposes. The thermal task
|
|
* doesn't do anything that could clear it. */
|
|
|
|
all_temps(50);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 0);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
|
|
return EC_SUCCESS;
|
|
}
|
|
|
|
static int test_several_limits(void)
|
|
{
|
|
reset_mocks();
|
|
|
|
thermal_params[1].temp_host[EC_TEMP_THRESH_WARN] = 150;
|
|
thermal_params[1].temp_host[EC_TEMP_THRESH_HIGH] = 200;
|
|
thermal_params[1].temp_host[EC_TEMP_THRESH_HALT] = 250;
|
|
|
|
thermal_params[2].temp_host[EC_TEMP_THRESH_WARN] = 100;
|
|
thermal_params[2].temp_host[EC_TEMP_THRESH_HIGH] = 200;
|
|
thermal_params[2].temp_host[EC_TEMP_THRESH_HALT] = 300;
|
|
|
|
thermal_params[3].temp_host[EC_TEMP_THRESH_WARN] = 20;
|
|
thermal_params[3].temp_host[EC_TEMP_THRESH_HIGH] = 30;
|
|
thermal_params[3].temp_host[EC_TEMP_THRESH_HALT] = 40;
|
|
|
|
set_temps(500, 100, 150, 10);
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1); /* 1=low, 2=warn, 3=low */
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
set_temps(500, 50, -1, 10); /* 1=low, 2=X, 3=low */
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 0);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
set_temps(500, 170, 210, 10); /* 1=warn, 2=high, 3=low */
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 1);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
set_temps(500, 100, 50, 40); /* 1=low, 2=low, 3=high */
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 1);
|
|
TEST_ASSERT(cpu_shutdown == 0);
|
|
|
|
set_temps(500, 100, 50, 41); /* 1=low, 2=low, 3=shutdown */
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 1);
|
|
TEST_ASSERT(cpu_throttled == 1);
|
|
TEST_ASSERT(cpu_shutdown == 1);
|
|
|
|
all_temps(0); /* reset from shutdown */
|
|
sleep(2);
|
|
TEST_ASSERT(host_throttled == 0);
|
|
TEST_ASSERT(cpu_throttled == 0);
|
|
|
|
|
|
return EC_SUCCESS;
|
|
}
|
|
|
|
|
|
void run_test(void)
|
|
{
|
|
RUN_TEST(test_init_val);
|
|
RUN_TEST(test_sensors_can_be_read);
|
|
RUN_TEST(test_one_fan);
|
|
RUN_TEST(test_two_fans);
|
|
RUN_TEST(test_all_fans);
|
|
|
|
RUN_TEST(test_one_limit);
|
|
RUN_TEST(test_several_limits);
|
|
|
|
test_print_result();
|
|
}
|