mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2025-12-31 02:51:26 +00:00
726ce97002
If a user had already run util/ec3po/run_tests.sh, and then never modified any ec3po files, the presubmit check would list every file in the EC repo that was newer since the the last run. This included files such as build artifacts. BUG=chromium:575032 BRANCH=None TEST=Run ./util/ec3po/run_tests.sh once. Run make -j buildall, try to upload and verify that no nag message to run ec3po tests is presented. TEST=Touch an ec3po file, try to upload, verify that nag message about running ec3po unit tests is presented. Change-Id: I4f09bb76dcd85b570b57030197f4887bed85f1a7 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/321134 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Shawn N <shawnn@chromium.org>
35 lines
1.2 KiB
Bash
Executable File
35 lines
1.2 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Copyright (c) 2014 The Chromium OS Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
if [[ ! -e .tests-passed ]]; then
|
|
echo 'Unit tests have not passed. Please run "make buildall -j".'
|
|
exit 1
|
|
fi
|
|
|
|
changed=$(find ${PRESUBMIT_FILES} -newer .tests-passed)
|
|
ec3po_files=$(echo "${PRESUBMIT_FILES}" | grep util/ec3po/)
|
|
# Filter out ec3po files from changed files.
|
|
changed=$(echo "${changed}" | grep -v util/ec3po/)
|
|
if [[ -n "${changed}" ]]; then
|
|
echo "Files have changed since last time unit tests passed:"
|
|
echo "${changed}" | sed -e 's/^/ /'
|
|
echo 'Please run "make buildall -j".'
|
|
exit 1
|
|
fi
|
|
|
|
if [[ ! -e util/ec3po/.tests-passed ]] && [[ -n "${ec3po_files}" ]]; then
|
|
echo 'Unit tests have not passed. Please run "util/ec3po/run_tests.sh".'
|
|
exit 1
|
|
fi
|
|
|
|
changed_ec3po_files=$(find ${ec3po_files} -newer util/ec3po/.tests-passed)
|
|
if [[ -n "${changed_ec3po_files}" ]] && [[ -n "${ec3po_files}" ]]; then
|
|
echo "Files have changed since last time EC-3PO unit tests passed:"
|
|
echo "${changed_ec3po_files}" | sed -e 's/^/ /'
|
|
echo 'Please run "util/ec3po/run_tests.sh".'
|
|
exit 1
|
|
fi
|