mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2026-01-07 16:11:43 +00:00
bc11760a58
Currently, per-board defines use mixed case (BOARD_pit). This causes
the presubmit script to complain because that's a style violation.
Using --no-verify to bypass that also allows other style violations to
creep in.
This change adds uppercase variants (BOARD_PIT). It also adds a CORE_
define with '-' changed to '_', since CORE_cortex-m isn't a valid
symbol but CORE_CORTEX_M is (so now we can #ifdef CORE_CORTEX_M).
This does not remove the old mixed-case defines yet, nor does it
find/replace them in the C source files. This is intentional, so this
change can be cherry-picked into branches without needing to change
files in the branch that may have picked up new #ifdefs.
I will rename the constants in the C source files and remove the old
mixed-case defines in a follow-on CL, which should not need to get
picked into existing branches.
BUG=chromium:322144
BRANCH=none (but might need it if you later cherry-pick something with
an uppercase #ifdef BOARD_FOO
TEST=Build each board with V=1 option: 'make V=1 BOARD=foo all tests'.
Check that the compile command line has both mixed-case and
uppercase defines. Check that per-board tests from test/build.mk
were built (for example, BOARD_PIT should compile kb_scan and
stress, and BOARD_SAMUS should build none of them).
Change-Id: I5eb0d1fe57f1c694d7449e5f148e2f13fb290a39
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/179205
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
53 lines
1.5 KiB
Makefile
53 lines
1.5 KiB
Makefile
# -*- makefile -*-
|
|
# Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
#
|
|
# on-board test binaries build
|
|
#
|
|
|
|
test-list-y=pingpong timer_calib timer_dos timer_jump mutex utils
|
|
#disable: powerdemo
|
|
|
|
test-list-$(BOARD_BDS)+=
|
|
test-list-$(BOARD_PIT)+=kb_scan stress
|
|
test-list-$(BOARD_SNOW)+=kb_scan stress
|
|
test-list-$(BOARD_SPRING)+=kb_scan stress
|
|
|
|
# Samus has board-specific chipset code, and the tests don't
|
|
# compile with it. Disable them for now.
|
|
test-list-$(BOARD_SAMUS)=
|
|
|
|
# Emulator tests
|
|
test-list-host=mutex pingpong utils kb_scan kb_mkbp lid_sw power_button hooks
|
|
test-list-host+=thermal flash queue kb_8042 extpwr_gpio console_edit system
|
|
test-list-host+=sbs_charging adapter host_command thermal_falco led_spring
|
|
test-list-host+=bklight_lid bklight_passthru
|
|
|
|
adapter-y=adapter.o
|
|
bklight_lid-y=bklight_lid.o
|
|
bklight_passthru-y=bklight_passthru.o
|
|
console_edit-y=console_edit.o
|
|
extpwr_gpio-y=extpwr_gpio.o
|
|
flash-y=flash.o
|
|
hooks-y=hooks.o
|
|
host_command-y=host_command.o
|
|
kb_8042-y=kb_8042.o
|
|
kb_mkbp-y=kb_mkbp.o
|
|
kb_scan-y=kb_scan.o
|
|
led_spring-y=led_spring.o led_spring_impl.o
|
|
lid_sw-y=lid_sw.o
|
|
mutex-y=mutex.o
|
|
pingpong-y=pingpong.o
|
|
power_button-y=power_button.o
|
|
powerdemo-y=powerdemo.o
|
|
queue-y=queue.o
|
|
sbs_charging-y=sbs_charging.o
|
|
stress-y=stress.o
|
|
system-y=system.o
|
|
thermal-y=thermal.o
|
|
thermal_falco-y=thermal_falco.o
|
|
timer_calib-y=timer_calib.o
|
|
timer_dos-y=timer_dos.o
|
|
utils-y=utils.o
|