mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2025-12-29 18:11:05 +00:00
51f5875da6
When vendor commands are processed by the TPM device, the result of
the command execution is communicated through the TPM response header.
When vendor commands are sent through USB the command execution result
value is lost, as the USB reply includes only the response payload,
(if any), but not the result value.
With this patch the single byte result value is prepended to the USB
response payload. The recipient will always look for the value in the
first byte of the response to find the vendor command execution
status.
The corresponding change to the Cr50 usb_updater will remove the
response code from the payload before considering the command's return
data.
BRANCH=cr50
BUG=b:35587387,b:35587053
TEST=verified proper existing extension commands processing (post
reset, turn update on) by the new version of usb_updater and
backwards compatibility with earlier Cr50 RW version (down to
0.0.13).
Change-Id: I5c8b3ea71d3cbbaccc06c909754944b3ab04675d
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/525093
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
76 lines
2.6 KiB
C
76 lines
2.6 KiB
C
/* Copyright 2015 The Chromium OS Authors. All rights reserved.
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#ifndef __EC_INCLUDE_EXTENSION_H
|
|
#define __EC_INCLUDE_EXTENSION_H
|
|
|
|
#include <stddef.h>
|
|
#include <stdint.h>
|
|
|
|
#include "common.h"
|
|
#include "tpm_vendor_cmds.h"
|
|
|
|
/*
|
|
* Type of function handling extension commands.
|
|
*
|
|
* @param buffer As input points to the input data to be processed, as
|
|
* output stores data, processing result.
|
|
* @param command_size Number of bytes of input data
|
|
* @param response_size On input - max size of the buffer, on output - actual
|
|
* number of data returned by the handler.
|
|
*/
|
|
typedef enum vendor_cmd_rc (*extension_handler)(enum vendor_cmd_cc code,
|
|
void *buffer,
|
|
size_t command_size,
|
|
size_t *response_size);
|
|
|
|
/**
|
|
* Find handler for an extension command.
|
|
*
|
|
* Use the interface specific function call in order to check the policies for
|
|
* handling the commands on that interface.
|
|
*
|
|
* @param command_code Code associated with a extension command handler.
|
|
* @param buffer Data to be processd by the handler, the same space
|
|
* is used for data returned by the handler.
|
|
* @command_size Size of the input data.
|
|
* @param size On input - max size of the buffer, on output - actual number of
|
|
* data returned by the handler. A single byte return
|
|
* usually indicates an error and contains the error code.
|
|
*/
|
|
void usb_extension_route_command(uint16_t command_code,
|
|
void *buffer,
|
|
size_t command_size,
|
|
size_t *size);
|
|
uint32_t tpm_extension_route_command(uint16_t command_code,
|
|
void *buffer,
|
|
size_t command_size,
|
|
size_t *size);
|
|
|
|
/* Pointer table */
|
|
struct extension_command {
|
|
uint16_t command_code;
|
|
extension_handler handler;
|
|
} __packed;
|
|
|
|
#define DECLARE_EXTENSION_COMMAND(code, func) \
|
|
static enum vendor_cmd_rc func##_wrap(enum vendor_cmd_cc code, \
|
|
void *cmd_body, \
|
|
size_t cmd_size, \
|
|
size_t *response_size) { \
|
|
func(cmd_body, cmd_size, response_size); \
|
|
return 0; \
|
|
} \
|
|
const struct extension_command __keep __extension_cmd_##code \
|
|
__attribute__((section(".rodata.extensioncmds"))) \
|
|
= {.command_code = code, .handler = func##_wrap }
|
|
|
|
#define DECLARE_VENDOR_COMMAND(code, func) \
|
|
const struct extension_command __keep __vendor_cmd_##code \
|
|
__attribute__((section(".rodata.extensioncmds"))) \
|
|
= {.command_code = code, .handler = func}
|
|
|
|
#endif /* __EC_INCLUDE_EXTENSION_H */
|