From df1686a2ae580c00742b15b5c0a1dac573928600 Mon Sep 17 00:00:00 2001
From: Charles <charles.bourque96@gmail.com>
Date: Mon, 10 Apr 2023 11:04:05 +0200
Subject: [PATCH] [WIFI-12437] Improved commonly used device actions
 accessibility

Signed-off-by: Charles <charles.bourque96@gmail.com>
---
 package-lock.json                             |   4 +-
 package.json                                  |   2 +-
 .../Buttons/DeviceActionDropdown/index.tsx    | 125 ++++++++++++------
 src/pages/Device/Wrapper.tsx                  |   9 +-
 src/pages/Devices/ListCard/Actions.tsx        |   7 +-
 5 files changed, 94 insertions(+), 53 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index b0cadaf..249949b 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "ucentral-client",
-  "version": "2.10.0(5)",
+  "version": "2.10.0(11)",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "ucentral-client",
-      "version": "2.10.0(5)",
+      "version": "2.10.0(11)",
       "license": "ISC",
       "dependencies": {
         "@chakra-ui/icons": "^2.0.11",
diff --git a/package.json b/package.json
index e14fc48..b37f555 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ucentral-client",
-  "version": "2.10.0(5)",
+  "version": "2.10.0(11)",
   "description": "",
   "private": true,
   "main": "index.tsx",
diff --git a/src/components/Buttons/DeviceActionDropdown/index.tsx b/src/components/Buttons/DeviceActionDropdown/index.tsx
index c9cfafa..c486bcf 100644
--- a/src/components/Buttons/DeviceActionDropdown/index.tsx
+++ b/src/components/Buttons/DeviceActionDropdown/index.tsx
@@ -1,18 +1,17 @@
 import React from 'react';
 import {
-  Button,
   IconButton,
   Menu,
   MenuButton,
   MenuItem,
   MenuList,
   Portal,
-  Spinner,
   Tooltip,
+  useColorModeValue,
   useToast,
 } from '@chakra-ui/react';
 import axios from 'axios';
-import { Wrench } from 'phosphor-react';
+import { Barcode, Power, TerminalWindow, WifiHigh, Wrench } from 'phosphor-react';
 import { useTranslation } from 'react-i18next';
 import { useControllerStore } from 'contexts/ControllerSocketProvider/useStore';
 import { useBlinkDevice, useGetDeviceRtty } from 'hooks/Network/Devices';
@@ -51,12 +50,13 @@ const DeviceActionDropdown = ({
   onOpenScriptModal,
   onOpenRebootModal,
   size,
-  isCompact = true,
+  isCompact,
 }: Props) => {
   const { t } = useTranslation();
   const toast = useToast();
+  const connectColor = useColorModeValue('blackAlpha', 'gray');
   const addEventListeners = useControllerStore((state) => state.addEventListeners);
-  const { refetch: getRtty, isInitialLoading: isRtty } = useGetDeviceRtty({
+  const { refetch: getRtty, isFetching: isRtty } = useGetDeviceRtty({
     serialNumber: device.serialNumber,
     extraId: 'inventory-modal',
   });
@@ -162,49 +162,90 @@ const DeviceActionDropdown = ({
   const handleRebootClick = () => onOpenRebootModal(device.serialNumber);
 
   return (
-    <Menu>
-      <Tooltip label={t('common.actions')}>
-        {size === undefined || isCompact ? (
+    <>
+      <Tooltip label={t('commands.connect')}>
+        <IconButton
+          aria-label="Connect"
+          icon={<TerminalWindow size={20} />}
+          size={size ?? 'sm'}
+          isDisabled={isDisabled}
+          isLoading={isRtty}
+          onClick={handleConnectClick}
+          colorScheme={connectColor}
+          hidden={isCompact}
+        />
+      </Tooltip>
+      <Tooltip label={t('controller.configure.title')}>
+        <IconButton
+          aria-label={t('controller.configure.title')}
+          icon={<Barcode size={20} />}
+          size={size ?? 'sm'}
+          isDisabled={isDisabled}
+          onClick={handleOpenConfigure}
+          colorScheme="purple"
+          hidden={isCompact}
+        />
+      </Tooltip>
+      <Tooltip label={t('commands.reboot')}>
+        <IconButton
+          aria-label={t('commands.reboot')}
+          icon={<Power size={20} />}
+          size={size ?? 'sm'}
+          isDisabled={isDisabled}
+          onClick={handleRebootClick}
+          colorScheme="green"
+          hidden={isCompact}
+        />
+      </Tooltip>
+      <Tooltip label={t('commands.wifiscan')}>
+        <IconButton
+          aria-label={t('commands.wifiscan')}
+          icon={<WifiHigh size={20} />}
+          size={size ?? 'sm'}
+          isDisabled={isDisabled}
+          onClick={handleOpenScan}
+          colorScheme="teal"
+          hidden={isCompact}
+        />
+      </Tooltip>
+      <Menu>
+        <Tooltip label={t('common.actions')}>
           <MenuButton
             as={IconButton}
             aria-label="Commands"
-            icon={isRtty ? <Spinner /> : <Wrench size={20} />}
+            icon={<Wrench size={20} />}
             size={size ?? 'sm'}
             isDisabled={isDisabled}
-            ml={2}
           />
-        ) : (
-          <MenuButton
-            as={Button}
-            aria-label="Commands"
-            rightIcon={isRtty ? <Spinner /> : <Wrench size={20} />}
-            size={size ?? 'sm'}
-            isDisabled={isDisabled}
-            ml={2}
-          >
-            {t('common.actions')}
-          </MenuButton>
-        )}
-      </Tooltip>
-      <Portal>
-        <MenuList>
-          <MenuItem onClick={handleBlinkClick}>{t('commands.blink')}</MenuItem>
-          <MenuItem onClick={handleOpenConfigure}>{t('controller.configure.title')}</MenuItem>
-          <MenuItem onClick={handleConnectClick}>{t('commands.connect')}</MenuItem>
-          <MenuItem onClick={handleOpenQueue}>{t('controller.queue.title')}</MenuItem>
-          <MenuItem onClick={handleOpenFactoryReset}>{t('commands.factory_reset')}</MenuItem>
-          <MenuItem onClick={handleOpenUpgrade}>{t('commands.firmware_upgrade')}</MenuItem>
-          <MenuItem onClick={handleRebootClick}>{t('commands.reboot')}</MenuItem>
-          <MenuItem onClick={handleOpenTelemetry}>{t('controller.telemetry.title')}</MenuItem>
-          <MenuItem onClick={handleOpenScript}>{t('script.one')}</MenuItem>
-          <MenuItem onClick={handleOpenTrace}>{t('controller.devices.trace')}</MenuItem>
-          <MenuItem onClick={handleUpdateToLatest} hidden>
-            {t('premium.toolbox.upgrade_to_latest')}
-          </MenuItem>
-          <MenuItem onClick={handleOpenScan}>{t('commands.wifiscan')}</MenuItem>
-        </MenuList>
-      </Portal>
-    </Menu>
+        </Tooltip>
+        <Portal>
+          <MenuList maxH="315px" overflowY="auto">
+            <MenuItem onClick={handleBlinkClick}>{t('commands.blink')}</MenuItem>
+            <MenuItem onClick={handleOpenConfigure} hidden={!isCompact}>
+              {t('controller.configure.title')}
+            </MenuItem>
+            <MenuItem onClick={handleConnectClick} hidden={!isCompact}>
+              {t('commands.connect')}
+            </MenuItem>
+            <MenuItem onClick={handleOpenQueue}>{t('controller.queue.title')}</MenuItem>
+            <MenuItem onClick={handleOpenFactoryReset}>{t('commands.factory_reset')}</MenuItem>
+            <MenuItem onClick={handleOpenUpgrade}>{t('commands.firmware_upgrade')}</MenuItem>
+            <MenuItem onClick={handleRebootClick} hidden={!isCompact}>
+              {t('commands.reboot')}
+            </MenuItem>
+            <MenuItem onClick={handleOpenTelemetry}>{t('controller.telemetry.title')}</MenuItem>
+            <MenuItem onClick={handleOpenScript}>{t('script.one')}</MenuItem>
+            <MenuItem onClick={handleOpenTrace}>{t('controller.devices.trace')}</MenuItem>
+            <MenuItem onClick={handleUpdateToLatest} hidden>
+              {t('premium.toolbox.upgrade_to_latest')}
+            </MenuItem>
+            <MenuItem onClick={handleOpenScan} hidden={!isCompact}>
+              {t('commands.wifiscan')}
+            </MenuItem>
+          </MenuList>
+        </Portal>
+      </Menu>
+    </>
   );
 };
 
diff --git a/src/pages/Device/Wrapper.tsx b/src/pages/Device/Wrapper.tsx
index 7910478..30a69c6 100644
--- a/src/pages/Device/Wrapper.tsx
+++ b/src/pages/Device/Wrapper.tsx
@@ -185,7 +185,7 @@ const DevicePageWrapper = ({ serialNumber }: Props) => {
     <>
       {isCompact ? (
         <Card p={2} mb={4}>
-          <CardHeader overflowX="auto">
+          <CardHeader>
             <HStack spacing={2}>
               <Heading size="md">{serialNumber}</Heading>
               {connectedTag}
@@ -194,7 +194,7 @@ const DevicePageWrapper = ({ serialNumber }: Props) => {
             </HStack>
             <Spacer />
             <HStack spacing={2}>
-              {breakpoint !== 'base' && breakpoint !== 'md' && <DeviceSearchBar />}
+              <DeviceSearchBar />
               <DeleteButton isCompact onClick={onDeleteOpen} />
               {getDevice?.data && (
                 <DeviceActionDropdown
@@ -261,7 +261,6 @@ const DevicePageWrapper = ({ serialNumber }: Props) => {
                     onOpenRebootModal={rebootModalProps.onOpen}
                     onOpenScriptModal={scriptModal.openModal}
                     size="md"
-                    isCompact
                   />
                 )}
                 <RefreshButton
@@ -282,7 +281,9 @@ const DevicePageWrapper = ({ serialNumber }: Props) => {
             <AlertDialogHeader fontSize="lg" fontWeight="bold">
               {t('crud.delete')} {serialNumber}
             </AlertDialogHeader>
+
             <AlertDialogBody>{t('crud.delete_confirm', { obj: t('devices.one') })}</AlertDialogBody>
+
             <AlertDialogFooter>
               <Button colorScheme="gray" mr="1" onClick={onDeleteClose} ref={cancelRef}>
                 {t('common.cancel')}
@@ -306,7 +307,7 @@ const DevicePageWrapper = ({ serialNumber }: Props) => {
       <Box mt={isCompact ? '0px' : '68px'}>
         <Masonry
           breakpointCols={{
-            default: 3,
+            default: 2,
             2200: 2,
             1100: 1,
           }}
diff --git a/src/pages/Devices/ListCard/Actions.tsx b/src/pages/Devices/ListCard/Actions.tsx
index 7692ec3..7e721ef 100644
--- a/src/pages/Devices/ListCard/Actions.tsx
+++ b/src/pages/Devices/ListCard/Actions.tsx
@@ -3,7 +3,7 @@ import {
   Box,
   Button,
   Center,
-  Flex,
+  HStack,
   IconButton,
   Link,
   Popover,
@@ -64,7 +64,7 @@ const Actions: React.FC<Props> = ({
     });
 
   return (
-    <Flex>
+    <HStack spacing={2}>
       <Popover isOpen={isOpen} onOpen={onOpen} onClose={onClose}>
         <Tooltip hasArrow label={t('crud.delete')} placement="top" isDisabled={isOpen}>
           <Box>
@@ -110,14 +110,13 @@ const Actions: React.FC<Props> = ({
         <Link href={`#/devices/${device.serialNumber}`}>
           <IconButton
             aria-label={t('common.view_details')}
-            ml={2}
             colorScheme="blue"
             icon={<MagnifyingGlass size={20} />}
             size="sm"
           />
         </Link>
       </Tooltip>
-    </Flex>
+    </HStack>
   );
 };