From 0bb204fdc8eed706fb360ded2ce48c4e512657b7 Mon Sep 17 00:00:00 2001
From: Martin Pulec <martin.pulec@cesnet.cz>
Date: Thu, 22 Sep 2022 10:00:20 +0200
Subject: [PATCH] video decoder: count dropped frames

Count dropped frames from display. It was broken from some time point
and the count of dropped frames was always 0.

+ make some things prettier (alphabetic order, one-line assignment)
---
 src/rtp/video_decoders.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/rtp/video_decoders.cpp b/src/rtp/video_decoders.cpp
index 7c261531d..a9071731f 100644
--- a/src/rtp/video_decoders.cpp
+++ b/src/rtp/video_decoders.cpp
@@ -287,6 +287,7 @@ struct frame_msg {
                         }
                         stats.corrupted += is_corrupted;
                         stats.displayed += is_displayed;
+                        stats.dropped += !is_displayed;
                 }
                 vf_free(recv_frame);
                 vf_free(nofec_frame);
@@ -298,8 +299,8 @@ struct frame_msg {
         unique_ptr<map<int, int>[]> pckt_list;
         unsigned long long int received_pkts_cum, expected_pkts_cum;
         struct reported_statistics_cumul &stats;
-        bool is_displayed = false;
         bool is_corrupted = false;
+        bool is_displayed = false;
 };
 
 struct main_msg_reconfigure {
@@ -710,9 +711,7 @@ static void *decompress_thread(void *args) {
                         decoder->frame->ssrc = msg->nofec_frame->ssrc;
                         int ret = display_put_frame(decoder->display,
                                         decoder->frame, putf_flags);
-                        if (ret == 0) {
-                                msg->is_displayed = true;
-                        }
+                        msg->is_displayed = ret == 0;
                         decoder->frame = display_get_frame(decoder->display);
                 }