From 15483cd57795db732f081473e1c74eee5fb55eab Mon Sep 17 00:00:00 2001 From: Martin Pulec Date: Thu, 4 May 2023 08:37:37 +0200 Subject: [PATCH] DeckLink disp.: set LowLatency opt in a usual way Do not link bmdDeckLinkConfigLowLatencyVideoOutput with `-d decklink:low_latency` option because these features are not necessarily related - the BMD feature (according to the docs) is even not honored by recent devices and doesn't have an impact on our "low_latency" (scheduled/not scheduled) mode of operating. --- src/video_display/decklink.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/video_display/decklink.cpp b/src/video_display/decklink.cpp index 681082bf0..2adfe0cf0 100644 --- a/src/video_display/decklink.cpp +++ b/src/video_display/decklink.cpp @@ -352,6 +352,7 @@ struct state_decklink { { bmdDeckLinkConfigVideoOutputIdleOperation, bmd_option{(int64_t) bmdIdleVideoOutputLastFrame, false} }, { bmdDeckLinkConfigOutput1080pAsPsF, bmd_option{false, false}}, { bmdDeckLinkConfigFieldFlickerRemoval, bmd_option{false, false}}, ///< required for interlaced video in low-latency + { bmdDeckLinkConfigLowLatencyVideoOutput, bmd_option{true, false}} }; HDRMetadata requested_hdr_mode{}; @@ -1244,10 +1245,6 @@ static void *display_decklink_init(struct module *parent, const char *fmt, unsig } } - if (!bmd_option(s->low_latency).option_write(deckLinkConfiguration, bmdDeckLinkConfigLowLatencyVideoOutput)) { - goto error; - } - if (s->sdi_dual_channel_level != BMD_OPT_DEFAULT) { if (deckLinkAttributes) { BMD_BOOL supports_level_a;