scottk/UltraGrid
1
0
Fork 0
mirror of https://github.com/outbackdingo/UltraGrid.git synced 2026-03-22 01:40:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

do not use source TS as RTP TS by default

Browse Source 
Do not use source TS as (a base for) RTP TS by default anymore. Since this
was essential for synchronized DeckLink playback, require `--incompatible`
to enable this.

The reason to disable for now is because it breaks compressed
audio. Eg. for Opus, one receives 2 packets for 40 ms input. Currently
only the first gets source TS, second is undefined, thus getting the
default, loosely related TS, that may however create TS discontinuity
(especially with the time, when PC and DeckLink time diverges).

There is no good solution for the above yet, sending both packet with
the same TS and m-bit on second isn't sufficient now, because it gets
joined in receiver buffer and eg. Opus is not self delimiting so it will
need changes on receiver side to pass RTP packets to Opus decoder as
Opus packets.

refer to GH-326
This commit is contained in:
Martin Pulec
2023-07-26 16:03:45 +02:00
parent b634053b99
commit 2f1bfa9340
3 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/host.cpp
View File

@@ -107,7 +107,7 @@ using namespace std;
unsigned int audio_capture_channels = 0;
unsigned int audio_capture_bps = 0;
unsigned int audio_capture_sample_rate = 0;
bool incompatible_features = false;
unsigned int cuda_devices[MAX_CUDA_DEVICES] = { 0 };
unsigned int cuda_devices_count = 1;
@@ -426,6 +426,10 @@ struct init_data *common_preinit(int argc, char *argv[])
load_libgcc();
if (get_commandline_param("incompatible") != nullptr) {
incompatible_features = true;
}
return new init_data{init};
}
@@ -1065,6 +1069,8 @@ ADD_TO_PARAM("debug-dump", "* debug-dump=<module>[=<n>][,<module2>[=<n>]\n"
" Dumps specified buffer for debugging, n-th buffer may be selected, name is <module>.dump.\n"
" Avaiable modules: lavd-uncompressed\n");
#endif
ADD_TO_PARAM("incompatible", "* incompatible\n"
" Features that may possibly not be compatible with at least older or even any other UG version.\n");
ADD_TO_PARAM("low-latency-audio", "* low-latency-audio[=ultra]\n"
" Try to reduce audio latency at the expense of worse reliability\n"
" Add ultra for even more aggressive setting.\n");