From 65e2009e41cf08f37be6345e351966c04b43bddb Mon Sep 17 00:00:00 2001 From: Martin Piatka Date: Wed, 22 Mar 2023 13:03:26 +0100 Subject: [PATCH] capabilities: Fix off by one strncpy --- src/video_display.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/video_display.c b/src/video_display.c index a8e8c496e..47974004f 100644 --- a/src/video_display.c +++ b/src/video_display.c @@ -633,9 +633,9 @@ void dev_add_option(struct device_info *dev, const char *name, const char *desc, while(*dev->options[idx].key) idx++; - strncpy(dev->options[idx].display_name, name, sizeof(dev->options[idx].display_name)); - strncpy(dev->options[idx].display_desc, desc, sizeof(dev->options[idx].display_desc)); - strncpy(dev->options[idx].key, key, sizeof(dev->options[idx].key)); - strncpy(dev->options[idx].opt_str, opt_str, sizeof(dev->options[idx].opt_str)); + strncpy(dev->options[idx].display_name, name, sizeof(dev->options[idx].display_name) - 1); + strncpy(dev->options[idx].display_desc, desc, sizeof(dev->options[idx].display_desc) - 1); + strncpy(dev->options[idx].key, key, sizeof(dev->options[idx].key) - 1); + strncpy(dev->options[idx].opt_str, opt_str, sizeof(dev->options[idx].opt_str) - 1); dev->options[idx].is_boolean = is_boolean; }