scottk/UltraGrid
1
0
Fork 0
mirror of https://github.com/outbackdingo/UltraGrid.git synced 2026-03-22 03:40:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

RTP video decoder: check bounds also for compressed/FEC

Browse Source 
Check bounds also for compressed/FEC streams to avoid crashes and/or
potential attacks. This can occur for instance when VR has some
unexpected data outside the buffer.
This commit is contained in:
Martin Pulec
2021-06-21 11:05:31 +02:00
parent 3dd7a82a69
commit 711eb170ad
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/rtp/video_decoders.cpp
View File

@@ -1793,6 +1793,14 @@ int decode_video_frame(struct coded_data *cdata, void *decoder_data, struct pbuf
frame->tiles[substream].data = (char *) malloc(buffer_length + PADDING); frame->tiles[substream].data = (char *) malloc(buffer_length + PADDING);
} }
if (data_pos + len >= (unsigned) buffer_length) {
if((prints % 100) == 0) {
log_msg(LOG_LEVEL_ERROR, "WARNING!! Discarding input data as frame buffer is too small.\n"
"Well this should not happened. Expect troubles pretty soon.\n");
}
prints++;
len = max<int>(0, buffer_length - data_pos);
}
memcpy(frame->tiles[substream].data + data_pos, (unsigned char*) data, memcpy(frame->tiles[substream].data + data_pos, (unsigned char*) data,
len); len);
} }